-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(storybook): update Percy config, add plex CDN as an allowed hostname #18007
fix(storybook): update Percy config, add plex CDN as an allowed hostname #18007
Conversation
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18007 +/- ##
=======================================
Coverage 81.78% 81.78%
=======================================
Files 406 406
Lines 14048 14048
Branches 4356 4409 +53
=======================================
Hits 11489 11489
+ Misses 2397 2396 -1
- Partials 162 163 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🫶 Thank you for this! Percy has been super annoying
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me!
7f7d88a
I've been noticing that we've been having some churn on our Percy status checks since #17308. I believe this config update should ensure that plex always loads from the CDN and we'll stop seeing snapshots using non-plex fonts.
Changelog
New
Testing / Reviewing