Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storybook): update Percy config, add plex CDN as an allowed hostname #18007

Merged

Conversation

tay1orjones
Copy link
Member

I've been noticing that we've been having some churn on our Percy status checks since #17308. I believe this config update should ensure that plex always loads from the CDN and we'll stop seeing snapshots using non-plex fonts.

Changelog

New

  • add akamai cdn as an allowed hostname in percy config

Testing / Reviewing

  • Review the percy status check, there may be some snapshot updates needed but they should all be using Plex and not another font

@tay1orjones tay1orjones requested a review from a team as a code owner November 6, 2024 17:31
@tay1orjones tay1orjones self-assigned this Nov 6, 2024
Copy link

netlify bot commented Nov 6, 2024

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit 11547cc
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-web-components/deploys/672ba7d899a1d700089ba4b5
😎 Deploy Preview https://deploy-preview-18007--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 6, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 11547cc
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/672ba7d84ba66e0008595d98
😎 Deploy Preview https://deploy-preview-18007--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 6, 2024

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit 11547cc
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/672ba7d853bcc60008db5a36
😎 Deploy Preview https://deploy-preview-18007--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.78%. Comparing base (aa67ac9) to head (11547cc).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #18007   +/-   ##
=======================================
  Coverage   81.78%   81.78%           
=======================================
  Files         406      406           
  Lines       14048    14048           
  Branches     4356     4409   +53     
=======================================
  Hits        11489    11489           
+ Misses       2397     2396    -1     
- Partials      162      163    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@alisonjoseph alisonjoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🫶 Thank you for this! Percy has been super annoying

Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@emyarod emyarod added this pull request to the merge queue Nov 6, 2024
Merged via the queue into carbon-design-system:main with commit 7f7d88a Nov 6, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants