feat(DataTable): add double toolbar prop #17868
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All contributors have signed the DCO. |
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
I have read the DCO document and I hereby sign the DCO. |
pilarfernandezz
force-pushed
the
17844-double-toolbar
branch
from
072f537 to
3c11b38
Compare
tay1orjones
requested changes
Oct 28, 2024
There was a problem hiding this comment.
Before we can review this we need a finalized spec from design, #17844 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #17844
This PR allows both Batch Actions and Actions toolbars to be displayed simultaneously.
Right now the Batch Actions toolbar overrides the Actions toolbar when there is some row selected. With that, the search bar and actions buttons can not be changed/clicked.
Changelog
New
useDoubleToolbarproperty to Table and TableToolbar.Changed
false, maintaining the current behavior.truethe Batch Actions toolbar will be displayed bellow the Actions toolbar.Testing / Reviewing
Change the prop to true and select any row in the DataTable. The blue Batch Actions toolbar should be displayed bellow the Actions toolbar. Should be possible to click in the Actions buttons and edit the search bar input.
