Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Unit test] - Dismissible Tag #17716

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

guidari
Copy link
Contributor

@guidari guidari commented Oct 10, 2024

Closes #17504

Added tests for dismissible tag
We are gonna remove slug in this #17706, so we don't have to cover that part

Testing / Reviewing

  • Test should be at 95.23

Copy link

netlify bot commented Oct 10, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 5a5a905
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/670980d4613d8300080100ec
😎 Deploy Preview https://deploy-preview-17716--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 10, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 5a5a905
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/670980d4d1071000081583c6
😎 Deploy Preview https://deploy-preview-17716--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.02%. Comparing base (993fb9c) to head (5a5a905).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17716      +/-   ##
==========================================
+ Coverage   78.96%   79.02%   +0.05%     
==========================================
  Files         408      407       -1     
  Lines       14020    14006      -14     
  Branches     4381     4372       -9     
==========================================
- Hits        11071    11068       -3     
+ Misses       2782     2771      -11     
  Partials      167      167              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increase DismissibleTag unit test coverage
2 participants