refactor: add typescript types to togglesmall and portal #17712
Conversation
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17712 +/- ##
==========================================
+ Coverage 78.33% 78.95% +0.61%
==========================================
Files 408 407 -1
Lines 14015 14012 -3
Branches 4324 4375 +51
==========================================
+ Hits 10979 11063 +84
+ Misses 2868 2783 -85
+ Partials 168 166 -2 ☔ View full report in Codecov by Sentry. |
| * LICENSE file in the root directory of this source tree. | ||
| */ | ||
|
|
||
| import PropTypes from 'prop-types'; |
There was a problem hiding this comment.
Portal isn't within /internal but isn't exported, so I agree removing proptypes is a good option here 👍
| /** | ||
| * Copyright IBM Corp. 2016, 2023 | ||
| * | ||
| * This source code is licensed under the Apache-2.0 license found in the | ||
| * LICENSE file in the root directory of this source tree. | ||
| */ |
There was a problem hiding this comment.
Did you remove the copyright info accidentally?
There was a problem hiding this comment.
Yeah, sorry i missed them when copying from the js file
Gururajj77
changed the title
Closes #17699
Closes #17698
added typescript types to
ToggleSmallandPortalcomponent.Changelog
New
ToggleSmallSkeletopPropsandPortalPropsto the components.Testing / Reviewing
no test should fail because of this.