fix: increase test coverage for ToggleTip #17661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17661 +/- ##
==========================================
+ Coverage 77.36% 77.50% +0.14%
==========================================
Files 409 409
Lines 14077 14077
Branches 4344 4372 +28
==========================================
+ Hits 10890 10911 +21
+ Misses 3017 2997 -20
+ Partials 170 169 -1 ☔ View full report in Codecov by Sentry. |
packages/react/src/components/Toggletip/__tests__/Toggletip-test.js
Outdated
Show resolved
Hide resolved
packages/react/src/components/Toggletip/__tests__/Toggletip-test.js
Outdated
Show resolved
Hide resolved
ariellalgilmore
approved these changes
Oct 9, 2024
Gururajj77
approved these changes
Oct 9, 2024
alisonjoseph
added
status: ready to merge 🎉
and removed
status: one more review 👀
labels
Merged
via the queue into
carbon-design-system:main
with commit Oct 9, 2024
9d1822c
36 checks passed
annawen1
pushed a commit
to annawen1/carbon
that referenced
this pull request
Oct 11, 2024
* fix: increase test coverage for ToggleTip * refactor: userEvent over fireEvent --------- Co-authored-by: Alison Joseph <alison.joseph@us.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #17498
This PR increases test coverage got ToggleTip
Changelog
Added new test cases
Testing / Reviewing
Test coverage should increase
Verify that test makes sense