Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed the aria-label assigning to wrapper div of dropdown #17588

Merged

Conversation

Gururajj77
Copy link
Contributor

Closes #17558

aria-label value, which was getting assigned to the wrapper div which encircles the dropdown, was caused by downshift's change, is fixed.

Changelog

New

  • Nothing's new

Changed

  • passing aria-label prop to the downshift's getToggleButtonProps()

Removed

  • removed aria-label prop that has been passed to ListBox

Testing / Reviewing

  • Navigate to Dropdown component's playground story from deploy preview
  • In the controls section, add aria-label as "test" or anything of you liking
  • Run the IBM's accessibility checker extension after going to full view mode on the component
  • The accessibility violations mentioned in the parent issue should not persist.

Copy link

netlify bot commented Sep 26, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 96e1e41
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/66fa2cc0eda0c80008bd71c6
😎 Deploy Preview https://deploy-preview-17588--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Sep 26, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 96e1e41
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/66fa2cc0226de70008488ac7
😎 Deploy Preview https://deploy-preview-17588--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.03%. Comparing base (29a4646) to head (96e1e41).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #17588   +/-   ##
=======================================
  Coverage   77.03%   77.03%           
=======================================
  Files         408      408           
  Lines       13993    13993           
  Branches     4301     4321   +20     
=======================================
  Hits        10779    10779           
+ Misses       3042     3041    -1     
- Partials      172      173    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kennylam kennylam added this pull request to the merge queue Oct 2, 2024
Merged via the queue into carbon-design-system:main with commit 1622642 Oct 2, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[a11y]: Dropdown aria-label prop isn't applied to the correct element
3 participants