Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tests for FluidTimePicker #17541

Merged
merged 2 commits into from
Oct 8, 2024

Conversation

guidari
Copy link
Contributor

@guidari guidari commented Sep 20, 2024

Closes #17516

Added tests for FluiTimePicker

Testing / Reviewing

  • CI should pass

@guidari guidari requested a review from a team as a code owner September 20, 2024 19:59
Copy link

netlify bot commented Sep 20, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit a005c1e
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/670566eb7a394300087db149
😎 Deploy Preview https://deploy-preview-17541--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Sep 20, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit a005c1e
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/670566eb47a927000844b97f
😎 Deploy Preview https://deploy-preview-17541--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.14%. Comparing base (a179e4b) to head (a005c1e).
Report is 775 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17541      +/-   ##
==========================================
+ Coverage   76.95%   77.14%   +0.18%     
==========================================
  Files         408      409       +1     
  Lines       13979    14024      +45     
  Branches     4291     4359      +68     
==========================================
+ Hits        10758    10819      +61     
+ Misses       3048     3035      -13     
+ Partials      173      170       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome! Just one small thing

</FluidTimePicker>
);

fireEvent.click(screen.getByRole('textbox'));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this use userEvent instead? It more realistically simulates the interaction, see here

@Gururajj77 Gururajj77 changed the title Added tests for FluiTimePicker Added tests for FluidTimePicker Sep 24, 2024
Copy link
Member

@kennylam kennylam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending Taylor's comment.

@tay1orjones tay1orjones added this pull request to the merge queue Oct 8, 2024
Merged via the queue into carbon-design-system:main with commit 348b3b5 Oct 8, 2024
36 checks passed
@carbon-automation
Copy link
Contributor

Hey there! v11.68.0 was just released that references this issue/PR.

annawen1 pushed a commit to annawen1/carbon that referenced this pull request Oct 11, 2024
* test: added tests for FluiTimePicker

* fix: changed from fireevent to userevent
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increase FluidTimePicker.Skeleton unit test coverage
3 participants