Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(definitiontooltip): increase test coverage to 100% #17434

Conversation

tay1orjones
Copy link
Member

Closes #17415

Changelog

New

  • added new tests for various functionality that was previously untested

Testing / Reviewing

  • Codecov should report 100% for DefinitionTooltip
  • CI should pass

Copy link

netlify bot commented Sep 12, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 4208502
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/67056a6a89c3440008cf99c6
😎 Deploy Preview https://deploy-preview-17434--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Sep 12, 2024

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit 1807e6a
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/66e3460186457900087fef23
😎 Deploy Preview https://deploy-preview-17434--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Sep 12, 2024

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit 4208502
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/67056a6a502dfe00088cfb2f
😎 Deploy Preview https://deploy-preview-17434--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Sep 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.13%. Comparing base (df9ec56) to head (4208502).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17434      +/-   ##
==========================================
+ Coverage   77.08%   77.13%   +0.05%     
==========================================
  Files         409      409              
  Lines       14024    14024              
  Branches     4327     4307      -20     
==========================================
+ Hits        10810    10818       +8     
+ Misses       3043     3036       -7     
+ Partials      171      170       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alisonjoseph
Copy link
Member

alisonjoseph commented Sep 12, 2024

Does this mean its 100% now? Just want to make sure I'm looking at the right thing. Screenshot 2024-09-12 at 3 12 51 PM

@2nikhiltom
Copy link
Contributor

How do we check the test coverage percentage locally ?

@guidari
Copy link
Contributor

guidari commented Sep 13, 2024

How do we check the test coverage percentage locally ?

Hey @2nikhiltom
Just run this command to get the percentage locally:
yarn test packages/react/src/components/Tooltip/__tests__/DefinitionTooltip-test.js --coverage --collectCoverageFrom=packages/react/src/components/Tooltip/DefinitionTooltip.tsx

We left this tips in the comment here

@guidari
Copy link
Contributor

guidari commented Sep 13, 2024

Does this mean its 100% now? Just want to make sure I'm looking at the right thing. ![Screenshot 2024-09-12 at 3 12

@alisonjoseph Yeah that's is correct!
Here it is the previous percentage vs the new one you just screen shoted

Copy link
Member

@alisonjoseph alisonjoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple tiny cleanup things but test coverage looks good 💯

Copy link
Contributor

@guidari guidari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good after the clean up from Alison's comment

@tay1orjones
Copy link
Member Author

Updated, thanks everyone!

@tay1orjones tay1orjones added this pull request to the merge queue Oct 8, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 8, 2024
@guidari guidari added this pull request to the merge queue Oct 8, 2024
Merged via the queue into carbon-design-system:main with commit 21e4380 Oct 8, 2024
23 checks passed
@carbon-automation
Copy link
Contributor

Hey there! v11.68.0 was just released that references this issue/PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add test coverage for DefinitionTooltip
5 participants