Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency inquirer to v10 - abandoned #17204

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Aug 17, 2024

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
inquirer (source) ^8.1.0 -> ^10.0.0 age adoption passing confidence
inquirer (source) ^6.4.1 -> ^10.0.0 age adoption passing confidence

Warning

Some dependencies could not be looked up. Check the Dependency Dashboard for more information.


Release Notes

SBoudrias/Inquirer.js (inquirer)

v10.1.8

Compare Source

v10.1.7

Compare Source

v10.1.6

Compare Source

v10.1.5

Compare Source

v10.1.4

Compare Source

v10.1.3

Compare Source

v10.1.2

Compare Source

v10.1.1

Compare Source

v10.1.0

Compare Source

  • Adds the new { type: 'search' } prompt.

v10.0.4

Compare Source

v10.0.3

Compare Source

v10.0.2

Compare Source

v10.0.1

Compare Source

v10.0.0

Compare Source

  • Re-implemented with Typescript.
  • Adding CJS support (now inquirer is publishes a dual-build CJS/ESM.)
  • All core prompts are now coming from @inquirer/prompt.
  • Custom prompts now should be implemented with @inquirer/core. Custom prompts built on inquirer@9.x.x will keep working, but should plan a migration.
  • inquirer.ui.BottomBar is deleted.

My expectation is that this release should be a drop-in replacement for people using inquirer.prompt() and built-ins 🤞🏻. Please open an issue on Github if you run into issues migrating; it's a large rewrite and there might be a few sharp edges to cut! Hope you'll like this new release.

v9.3.6

Compare Source

v9.3.5

Compare Source

  • Fix issue with plugins relying on internal inquirer packages file structure.

v9.3.4

Compare Source

v9.3.3

Compare Source

v9.3.2

Compare Source

v9.3.1

Compare Source

  • Fix risk of prototype injection.

v9.3.0

Compare Source

  • Replace chalk with picolors.
  • Drop many dependencies in favour of native functions when possible.

No impact expected, but it's a large changes in dependencies. Let us know if you run into any issues upgrading!

v9.2.23

Compare Source

v9.2.22

Compare Source

  • editor prompt: Fixed compatibility issue between default and waitUserInput options. #​1405

v9.2.21

Compare Source

v9.2.20

Compare Source

v9.2.19

Compare Source

v9.2.18

Compare Source

v9.2.17

Compare Source

v9.2.16

Compare Source

v9.2.15

Compare Source

v9.2.14

Compare Source

v9.2.13

Compare Source

v9.2.12

Compare Source

v9.2.11

Compare Source

v9.2.10

Compare Source

v9.2.9

Compare Source

  • Modified lodash imports to help with tree-shaking
  • Replace unmaintained through dependency (only affect users of the old bottom bar)

v9.2.8

Compare Source

v9.2.7

Compare Source

v9.2.6

Compare Source

v9.2.5

Compare Source

v9.2.4

Compare Source

v9.2.3

Compare Source

v9.2.2

Compare Source

v9.2.1

Compare Source

v9.2.0

Compare Source

v9.1.5

Compare Source

v9.1.4

Compare Source

Fix issue with the default value disappearing from prompt.

v9.1.3

Compare Source

v9.1.2

Compare Source

v9.1.1

Compare Source

v9.1.0

Compare Source

v9.0.2

Compare Source

v9.0.1

Compare Source

v9.0.0

Compare Source

Inquirer is now a native Node ECMAScript module. This will require your Node runtime to support es modules, and your app to be an es module. Node documentation over here: https://nodejs.org/api/esm.html#modules-ecmascript-modules

If you cannot migrate, please remember you can keep using the v8.x release line until you're ready.

v8.2.6

Compare Source

  • Bugfix: Fix a dependency who became ESM only

Configuration

📅 Schedule: Branch creation - "after 10pm every weekday,before 5am every weekday,every weekend" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Never, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot requested a review from a team as a code owner August 17, 2024 03:39
@renovate renovate bot requested review from alisonjoseph and tay1orjones August 17, 2024 03:39
Copy link

netlify bot commented Aug 17, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 4ae9fff
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/66c347068042a00008056f68
😎 Deploy Preview https://deploy-preview-17204--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Aug 17, 2024

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit 4ae9fff
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/66c347064d93ec00089ce654
😎 Deploy Preview https://deploy-preview-17204--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor Author

renovate bot commented Aug 19, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@tay1orjones
Copy link
Member

This is two majors, and while it looks like this should be an in-place upgrade, IIRC we have no tests on the cli package. To verify this one we need to test each command locally to ensure it still works. The upgrade package uses this as well.

@guidari guidari added the type: infrastructure 🤖 Issues relating to devops, tech debt, etc. label Aug 28, 2024
@kennylam
Copy link
Member

kennylam commented Aug 28, 2024

@tay1orjones Good call on the testing. The latest version is a no-go for @carbon/cli in its current state. As of v9, inquirer an ESM. So we'll have to refactor a few of the commands before upgrading. I can create a backlog issue for this, but in the meantime I think we can close this PR.

@kennylam
Copy link
Member

kennylam commented Sep 6, 2024

Blocked by #17194.

@renovate renovate bot changed the title chore(deps): update dependency inquirer to v10 chore(deps): update dependency inquirer to v10 - abandoned Sep 18, 2024
Copy link
Contributor Author

renovate bot commented Sep 18, 2024

Autoclosing Skipped

This PR has been flagged for autoclosing. However, it is being skipped due to the branch being already modified. Please close/delete it manually or report a bug if you think this is in error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: blocked 🙅‍♀️ type: infrastructure 🤖 Issues relating to devops, tech debt, etc.
Projects
Status: 🏗 In Progress
Development

Successfully merging this pull request may close these issues.

6 participants