Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: combobox's new feature, autocomplete with typeahead #16904

Closed

Conversation

Gururajj77
Copy link
Contributor

Closes #14007

Added autocomplete and typeahead feature for combobox with custom filter to support the typeahead.

Changelog

New

  • new autocomplete prop
  • new autocompleteCustomFunction which is 1-to-1 mapping filter function which filters matching both character and position.
  • new test to make sure autocomplete and autocompleteCustomFunction are working.

Changed

  • added getMenuProps and refs.setFloationg to useMemo hook
  • modified import for act in the test helpers

Testing / Reviewing

{{ Add descriptions, steps or a checklist for how reviewers can verify this PR works or not }}

Copy link

netlify bot commented Jul 2, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit bc58844
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/6683f87b39e2830008350a2a
😎 Deploy Preview https://deploy-preview-16904--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jul 2, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 02567e7
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/66c4b9200f15640008cf3016
😎 Deploy Preview https://deploy-preview-16904--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Gururajj77
Copy link
Contributor Author

Gururajj77 commented Aug 26, 2024

This draft PR is closed as the code is a bit outdated, and faced problems with IBM Plex, new PR at
#17268

@Gururajj77 Gururajj77 closed this Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ComboBox] Autocomplete implementation
2 participants