Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(border-subtle): bump value in dark themes #15415

Merged
merged 3 commits into from
Jan 4, 2024

Conversation

tw15egan
Copy link
Member

@tw15egan tw15egan commented Dec 18, 2023

Closes #14597

@janhassel pointed out that our dark theme $border-subtle values were lagging behind the corresponding $layer values.

Changelog

Changed

  • Bumped up the values of border-subtle-01 and border-subtle-02 in g90 and g100 so that they are visible in Layer Two and Layer Three. It seems a (possible) cause of this is that the Theme component assumes (and sets) a layer-one class by default, and not the background. We possibly need to look into setting a background class by default instead and creating new -00 layer tokens. See here and here. We also emit layer-01 at root, instead of a possible layer-00, but this is the easiest fix and doesn't open a can of worms.

Testing / Reviewing

Go to Layer --> Test Story to see value changes. Check other components in g90 and g100 to ensure the subtle borders look correct

Copy link

netlify bot commented Dec 18, 2023

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit e9362a0
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/6596db6b235d0d00084742fd
😎 Deploy Preview https://deploy-preview-15415--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tw15egan
Copy link
Member Author

@guidari and I bumped up values for the border-subtle-01 and border-subtle-02 tokens so that they were visible (see here for example). These changes would only affect a component in g90 or g100 on Layer Two or Layer Three. Let me know if these visual changes are acceptable -- You can view any With Layer story to see/inspect the changes or view the Percy link

@tw15egan tw15egan marked this pull request as ready for review December 18, 2023 14:48
@tw15egan tw15egan requested a review from a team as a code owner December 18, 2023 14:48
@tw15egan tw15egan requested review from alisonjoseph and removed request for guidari December 18, 2023 14:48
Copy link
Member

@alisonjoseph alisonjoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need to remove the test/demo stories before we can merge.

@tw15egan tw15egan added this pull request to the merge queue Jan 4, 2024
Merged via the queue into carbon-design-system:main with commit e88b0e1 Jan 4, 2024
20 checks passed
@tw15egan tw15egan deleted the border-subtle-fix branch January 4, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: $border-subtle is using previous step's value
5 participants