-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(border-subtle): bump value in dark themes #15415
fix(border-subtle): bump value in dark themes #15415
Conversation
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@guidari and I bumped up values for the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just need to remove the test/demo stories before we can merge.
e88b0e1
Closes #14597
@janhassel pointed out that our dark theme
$border-subtle
values were lagging behind the corresponding$layer
values.Changelog
Changed
border-subtle-01
andborder-subtle-02
ing90
andg100
so that they are visible inLayer Two
andLayer Three
. It seems a (possible) cause of this is that theTheme
component assumes (and sets) alayer-one
class by default, and not the background. We possibly need to look into setting abackground
class by default instead and creating new-00
layer tokens. See here and here. We also emit layer-01 at root, instead of a possible layer-00, but this is the easiest fix and doesn't open a can of worms.Testing / Reviewing
Go to
Layer --> Test Story
to see value changes. Check other components ing90
andg100
to ensure the subtle borders look correct