Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Typescript types to PrimaryButton and SecondaryButton #15405

Merged

Conversation

mattborghi
Copy link
Contributor

@mattborghi mattborghi commented Dec 17, 2023

Closes #13573 and #13569

Add Typescript types to Primary and SecondaryButton

Changelog

New

  • Add Typescript types to Primary and SecondaryButton

Changed

  • Renamed file extensions

Removed

  • N/A.

Testing / Reviewing

  • Storybook runs as before.
  • Unit tests passing.

@mattborghi mattborghi requested a review from a team as a code owner December 17, 2023 01:05
@mattborghi mattborghi changed the title Add Typescript types for SecondaryButton Add Typescript types to SecondaryButton Dec 17, 2023
Copy link

netlify bot commented Dec 17, 2023

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 7907e98
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/657e4ad8e9f40600089f17a5
😎 Deploy Preview https://deploy-preview-15405--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mattborghi mattborghi changed the title Add Typescript types to SecondaryButton Add Typescript types to PrimaryButton and SecondaryButton Dec 17, 2023
@guidari guidari added this pull request to the merge queue Dec 29, 2023
Merged via the queue into carbon-design-system:main with commit 17239c5 Dec 29, 2023
21 checks passed
danoro96 pushed a commit to danoro96/carbon that referenced this pull request Jan 18, 2024
…ign-system#15405)

* refactor: change file extensions for SecondaryButton

* refactor: add types for SecondaryButton

* refactor: add types for PrimaryButton
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add TypeScript types to SecondaryButton
3 participants