Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OverflowMenu fix when oppening two menus #15375

Merged
merged 9 commits into from
Dec 19, 2023

Conversation

guidari
Copy link
Contributor

@guidari guidari commented Dec 12, 2023

Closes #12942

Fixing the css selection by using the first-child

Changelog

Testing / Reviewing

  • Go to the Default stories of the OverflowMenu and try to open both menus
  • Delete duplicated OverflowMenu;
  • Tests should pass after deleting the duplicate OverflowMenu

@guidari guidari requested a review from a team as a code owner December 12, 2023 14:05
@guidari guidari changed the title 12942 overflow OverflowMenu fix when oppening two menus Dec 12, 2023
Copy link

netlify bot commented Dec 12, 2023

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit f612d7d
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/6581966bbe3d6a0008e55475
😎 Deploy Preview https://deploy-preview-15375--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@alisonjoseph alisonjoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tw15egan
Copy link
Collaborator

Looks good once test story is removed 👍🏻

@github-actions github-actions bot enabled auto-merge December 19, 2023 13:11
@github-actions github-actions bot added this pull request to the merge queue Dec 19, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Dec 19, 2023
@guidari guidari added this pull request to the merge queue Dec 19, 2023
Merged via the queue into carbon-design-system:main with commit 8efe38c Dec 19, 2023
21 checks passed
@guidari guidari deleted the 12942-overflow branch December 19, 2023 16:16
danoro96 pushed a commit to danoro96/carbon that referenced this pull request Jan 18, 2024
* fix: fixed overflow menu with an id

* fix: fixed overflow

* fix: added first-child selector

* fix: removed duplicated story

---------

Co-authored-by: Alison Joseph <alison.joseph@us.ibm.com>
Co-authored-by: TJ Egan <tw15egan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: OverflowMenuItem doesn't take focus if disabled
3 participants