feat(Copy): add copy align prop to CodeSnippet, Copy
#14653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
tw15egan
changed the title
CodeSnippet, Copy
guidari
approved these changes
Sep 14, 2023
alisonjoseph
approved these changes
Sep 15, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Merged
via the queue into
carbon-design-system:main
with commit Sep 18, 2023
1d12fb0
21 checks passed
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14652
Adds in the
alignprop toCodeSnippet,Copy, andCopyButtonso that they all allow customizable tooltips.Changelog
Changed
bottomvalue inCopy, we now allow a configurablealignprop, in line withIconButton(which it passes it down to)Testing / Reviewing
Ensure
CodeSnippetandCopyButtonexamples can have configurable popover alignments