Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AVT] - Added keyboard nav test Breadcrumb #14639

Merged
merged 9 commits into from
Sep 15, 2023

Conversation

guidari
Copy link
Contributor

@guidari guidari commented Sep 12, 2023

Closes #14638

Added keyboard navigation to Breadcrumb component.

Changelog

New

  • Added new file e2e/components/breadcrumb/breadcrumb-test.avt.e2e.js

Testing / Reviewing

  • Ensure the test pass.
  • Ensure that all the necessary navigation is covered.

@netlify
Copy link

netlify bot commented Sep 12, 2023

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 9b55acd
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/6504529f76d16100078498c8
😎 Deploy Preview https://deploy-preview-14639--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Sep 12, 2023

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 9b55acd
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/6504529f1b7aaf0007182d08
😎 Deploy Preview https://deploy-preview-14639--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small naming updates to help with #14595

e2e/components/breadcrumb/breadcrumb-test.avt.e2e.js Outdated Show resolved Hide resolved
e2e/components/breadcrumb/breadcrumb-test.avt.e2e.js Outdated Show resolved Hide resolved
e2e/components/breadcrumb/breadcrumb-test.avt.e2e.js Outdated Show resolved Hide resolved
e2e/components/breadcrumb/breadcrumb-test.avt.e2e.js Outdated Show resolved Hide resolved
e2e/components/breadcrumb/breadcrumb-test.avt.e2e.js Outdated Show resolved Hide resolved
e2e/components/breadcrumb/breadcrumb-test.avt.e2e.js Outdated Show resolved Hide resolved
Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tw15egan tw15egan added this pull request to the merge queue Sep 15, 2023
Merged via the queue into carbon-design-system:main with commit 616e981 Sep 15, 2023
17 checks passed
@guidari
Copy link
Contributor Author

guidari commented Sep 15, 2023

@tay1orjones FYI,

I had to changed the way I was expecting this test to work to pass. 
For some reason after clicking in a link, the playwright was failing in the CI and even with me increasing the timeout from default 3000ms to 120000ms, 500000ms… kept failing.

While I was trying to figure out this issue, I found that the tests written with test.slow() are not being run in the CI neither locally. I found that once I download the report from playwiright and took a deeper look, the tests are not being addressed there. Maybe we might have to re-write those tests in another way?

Screenshot 2023-09-14 at 16 51 20

If we search the title of the test with test.slow() it doesn't appear in the report.json from playwright.
Also it is the screenshot with a long timeout there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Keyboard Nav AVT test for Breadcrumb
3 participants