Skip to content

Conversation

@alisonjoseph
Copy link
Member

closes #10528

Changelog

Removed

  • remove aria-label on icon, not needed as the text inside the button is sufficient to describe what it does

Testing / Reviewing

Tests voiceover on show more/show less button on codesnippet and ensure it is only being read once

@alisonjoseph alisonjoseph requested a review from a team as a code owner October 27, 2022 16:17
@netlify
Copy link

netlify bot commented Oct 27, 2022

Deploy Preview for carbon-components-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit a218f4b
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/635ab739cb072f000a82c0ab
😎 Deploy Preview https://deploy-preview-12413--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Oct 27, 2022

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit a218f4b
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/635ab7399049d70008c59e44
😎 Deploy Preview https://deploy-preview-12413--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@kodiakhq kodiakhq bot merged commit d98b923 into carbon-design-system:main Oct 27, 2022
@carbon-bot
Copy link
Contributor

Hey there! v11.16.0 was just released that references this issue/PR.

@alisonjoseph alisonjoseph deleted the 10528-show-more-a11y-codessnippet branch October 28, 2022 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

[a11y]: 'show more' button on multiline codesnippet reads label multiple times

4 participants