Skip to content

Conversation

@tw15egan
Copy link
Contributor

@tw15egan tw15egan commented Oct 12, 2022

Refs #12127
Closes #12340

Initial PR adding in unstable__Select.

Changelog

New

  • unstable__FluidSelect component
  • Styles for FluidSelect (_fluid-select.scss)
  • Stories for FluidSelect (FluidSelect.stories.js)
  • Tests for FluidSelect

Testing / Reviewing

  • Go to the FluidSelect story and ensure all styles are correct, all variants render as expected, and all playground controls work.

@netlify
Copy link

netlify bot commented Oct 12, 2022

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 636cb41
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/6352da9342decf00086e09d7
😎 Deploy Preview https://deploy-preview-12290--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Oct 12, 2022

Deploy Preview for carbon-components-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 636cb41
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/6352da93a0d9a20008fe472a
😎 Deploy Preview https://deploy-preview-12290--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@tw15egan tw15egan force-pushed the fluid-select branch 2 times, most recently from 758852f to b971587 Compare October 14, 2022 15:33
@tw15egan tw15egan marked this pull request as ready for review October 14, 2022 15:50
@tw15egan tw15egan requested review from a team as code owners October 14, 2022 15:50
Copy link
Contributor

@aagonzales aagonzales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the disabled state the label and tooltip aren't disabled
image

Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome! 🎉

@tw15egan tw15egan requested a review from aagonzales October 19, 2022 20:36
Copy link
Contributor

@aagonzales aagonzales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@tw15egan
Copy link
Contributor Author

cc @aledavila

@kodiakhq kodiakhq bot merged commit 30cc810 into carbon-design-system:main Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Fluid inputs: Add FluidSelect experimental implementation

4 participants