Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(DatePicker): update tests to RTL #11802

Merged
merged 4 commits into from
Sep 12, 2022
Merged

chore(DatePicker): update tests to RTL #11802

merged 4 commits into from
Sep 12, 2022

Conversation

jnm2377
Copy link
Contributor

@jnm2377 jnm2377 commented Jul 14, 2022

Closes #11512

Changelog

  • updates tests to RTL

Testing / Reviewing

  • ensure all tests pass

@netlify
Copy link

netlify bot commented Jul 14, 2022 •
edited
Loading

✅ Deploy Preview for carbon-components-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit f79f038
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/631f6ddcf0895a00095204b3
😎 Deploy Preview https://deploy-preview-11802--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Jul 14, 2022 •
edited
Loading

✅ Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit f79f038
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/631f6ddc3b0e810009d7ffdb
😎 Deploy Preview https://deploy-preview-11802--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

tay1orjones
tay1orjones reviewed Jul 15, 2022
View reviewed changes
Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I came up with a few ideas for the ones you had comments on. Let me know if you wanna walk through them!

packages/react/src/components/DatePicker/DatePicker-test.js Outdated Show resolved Hide resolved
packages/react/src/components/DatePicker/DatePicker-test.js Outdated Show resolved Hide resolved
packages/react/src/components/DatePicker/DatePicker-test.js Outdated Show resolved Hide resolved
packages/react/src/components/DatePicker/DatePicker-test.js Outdated Show resolved Hide resolved
@jnm2377 jnm2377 marked this pull request as ready for review September 12, 2022 07:42
@jnm2377 jnm2377 requested a review from a team as a code owner September 12, 2022 07:42
tay1orjones
tay1orjones approved these changes Sep 12, 2022
View reviewed changes
Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@kodiakhq kodiakhq bot merged commit b9f56d9 into carbon-design-system:main Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aledavila aledavila aledavila approved these changes

@tay1orjones tay1orjones tay1orjones approved these changes

@tw15egan tw15egan Awaiting requested review from tw15egan tw15egan was automatically assigned from carbon-design-system/developers-system

@abbeyhrt abbeyhrt Awaiting requested review from abbeyhrt abbeyhrt was automatically assigned from carbon-design-system/developers-system

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
Design System
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use RTL for testing in DatePicker/DatePicker-test.js
3 participants
@jnm2377 @tay1orjones @aledavila