Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(FormLabel): update label with tooltip examples and styles #11779

Merged
merged 7 commits into from
Aug 5, 2022

Conversation

jnm2377
Copy link
Contributor

@jnm2377 jnm2377 commented Jul 12, 2022

Closes #11346

Changelog

  • updates form label with tooltip stories
  • no longer includes tooltip as child of label for a11y reasons
  • adds styles for label with tooltip

Testing / Reviewing

  • ensure all tests pass
  • view form label with tooltip story and ensure everything looks as expected (compare to v10 story)

@netlify
Copy link

netlify bot commented Jul 12, 2022

Deploy Preview for carbon-components-react ready!

Name Link
🔨 Latest commit 473b18e
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/62ed148da5ba2100073fd61d
😎 Deploy Preview https://deploy-preview-11779--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Jul 12, 2022

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 473b18e
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/62ed148d4a77f700092293ab
😎 Deploy Preview https://deploy-preview-11779--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@jnm2377 jnm2377 marked this pull request as ready for review July 12, 2022 15:38
@jnm2377 jnm2377 requested a review from a team as a code owner July 12, 2022 15:38
@jnm2377 jnm2377 requested review from tay1orjones and abbeyhrt July 12, 2022 15:38
Copy link
Contributor

@abbeyhrt abbeyhrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jnm2377 VRT is failing with this

Module not found: Error: Can't resolve '../Notification/next/Notification' in '/home/runner/work/carbon/carbon/packages/react/src/components/FormLabel'

I think the path just needs to be corrected within FormLabel story file?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Bug]: FormLabel with Tooltip is not displaying tooltip styles correctly
3 participants