Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(IconButton): adds hasIconOnly classname to fix right padding #11352

Merged
merged 5 commits into from
May 10, 2022

Conversation

jnm2377
Copy link
Contributor

@jnm2377 jnm2377 commented May 5, 2022

Closes #11295

Changelog

  • IconButton now uses cds--btn--icon-only and passes in a className prop
  • adds margin to the IconButton story so the tooltip wouldn't be overflowing

Testing / Reviewing

  1. View IconOnly story
  2. test the playground knobs for size & kind
  3. spacing should work correctly now (square btn not rectangle)

@netlify
Copy link

netlify bot commented May 5, 2022

Deploy Preview for carbon-components-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit eb6c510
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/627acbcb0c96870008383c75
😎 Deploy Preview https://deploy-preview-11352--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented May 5, 2022

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit eb6c510
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/627acbcb574ae90008187739
😎 Deploy Preview https://deploy-preview-11352--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@jnm2377 jnm2377 marked this pull request as ready for review May 5, 2022 22:16
@jnm2377 jnm2377 requested review from a team as code owners May 5, 2022 22:16
@jnm2377 jnm2377 requested review from abbeyhrt and dakahn May 5, 2022 22:16
@kodiakhq kodiakhq bot merged commit 3170235 into carbon-design-system:main May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: IconButton right padding is off
4 participants