Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(styles): add readonly text-input styles #10778

Merged
merged 4 commits into from
Feb 23, 2022
Merged

fix(styles): add readonly text-input styles #10778

merged 4 commits into from
Feb 23, 2022

Conversation

jnm2377
Copy link
Contributor

@jnm2377 jnm2377 commented Feb 17, 2022

Closes #10724

Changelog

Testing / Reviewing

  • check that all tests pass
  • ensure that v11 and v10 text input stories match stylistically (in v10, look at default story and check off the readOnly knob)

@jnm2377 jnm2377 requested a review from a team as a code owner February 17, 2022 17:18
@netlify
Copy link

netlify bot commented Feb 17, 2022 •
edited
Loading

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: fe30070

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/6215be970f801100071a8737

😎 Browse the preview: https://deploy-preview-10778--carbon-react-next.netlify.app

@netlify
Copy link

netlify bot commented Feb 17, 2022 •
edited
Loading

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: fe30070

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/6215be977781070008ebdd87

😎 Browse the preview: https://deploy-preview-10778--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Feb 17, 2022 •
edited
Loading

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: fe30070

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/6215be9711d63900077b9480

😎 Browse the preview: https://deploy-preview-10778--carbon-components-react.netlify.app

dakahn
dakahn approved these changes Feb 21, 2022
View reviewed changes
Copy link
Contributor

@dakahn dakahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good and reads well with JAWS on Windows 11

@kodiakhq kodiakhq bot merged commit f711831 into carbon-design-system:main Feb 23, 2022
@jnm2377 jnm2377 mentioned this pull request Feb 25, 2022
Closed
22 tasks
kennylam pushed a commit to kennylam/carbon that referenced this pull request Jul 30, 2024
@abdonrd
feat(ui-shell): close side-nav when click on the overlay (carbon-desi…
9b0d16a 
…gn-system#10778)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dakahn dakahn dakahn approved these changes

@tay1orjones tay1orjones tay1orjones approved these changes

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Audit text-input styles
3 participants
@jnm2377 @tay1orjones @dakahn