TimePicker: v11 audit

[abbeyhrt]

Audit

A designer and developer will pair on this audit, some tasks may be discipline focused. Follow the checklist below for the features and items to review. If there are no issues with the item then check the item as complete. If any problems or bugs come up when auditing add a comment to this issue with the problem and how to correct it (if you know how). Bugs do not need to be fixed while auditing.

Document the process you go through while auditing when checking off the list.

The idea here is that anyone could look at this issue and understand the process you went through to audit the component from the comments below.

Resources

• Design spec in Sketch
• V11 Website
• SCSS
• Storybook

Checklist

Visual (in React code)
Design and dev check

• Component is using the correct design tokens (color and type), see design spec and scss code.
• Component is rendering correctly across themes and layers, see design spec and storybook.
  • White theme
  • Gray 10 theme
  • Gray 90 theme
  • Gray 100 theme
• Component is rendering correctly across browsers (check themes across browsers as well), see storybook.
  • Firefox
  • Safari
  • Chrome
• Component sizes are rendering and named correctly (if applicable)

Website (v11)
Design checks

• Style tab has correct design tokens listed
• Style and usage tabs are using the correct size props names (if applicable)
• Usage tab is up-to-date for with any v11 behavioral changes (if any)
• Live Demo has applied v11 changes
  • Themes are rendering correctly
  • Size props are named correctly
  • No light props included

Design Kits (Sketch only)
Design checks

• Correct design tokens (type and color) are used
• Component using the correct size prop names
• Any additional v11 behaviors have been added

Storybook
Dev checks

• Confirm that prop table is populating
• Take note of missing examples/stories (if any)

React package
Dev checks

• Go to https://codesandbox.io/s/github/carbon-design-system/carbon/tree/main/packages/react/examples/codesandbox and confirm that you can use the component as expected from @carbon/react

Accessibility
Dev checks

• Confirm that there are no violations in Accessibility checker
• Confirm that component works as expected with VoiceOver
• Confirm that the component looks and works as expected when zoomed 200%
• Confirm that the component is keyboard accessible. Ensure that everything you do with a mouse can be done with a keyboard and document in the comments how to interact with the component through a keyboard (not applicable to component with no interactive elements like Grid)

Migration docs
Design and dev check

• Any breaking changes to this component are present in the v11 migration guide.
  • Design
  • Develop

[thyhmdo]

Website

Live demo

• Remove light prop

[thyhmdo]

VIsual (React)

• Remove light prop

[jnm2377]

• Tested in our example directory using the latest @carbon/react and everything is working as expected.
• Story examples also look correct in different themes & browsers
• Prop tables are showing on storybook, and updated the light prop on the table in this PR fix(TimePicker): update light propType for storybook table #10945
• Only breaking changes in v11 is the refactor to functional component which is mentioned here: https://github.com/carbon-design-system/carbon/blob/main/docs/migration/v11.md#carbon-components-react
• Tested a11y checker and there are no violations
• VoiceOver is working as expected
• Keyboard working as expected
• Only thing to note, is playground story hasn't been added (w/ different sizes), that's being added/tracked in a separate issue Ensure playground stories have working controls #10751

sm

md

lg

disabled

invalid

[laurenmrice]

Design kit

White theme

• Enabled, Hover, and Filled states of the hour/minute input does not have a border-bottom. It needs to be added back.