Skip to content

Commit

Permalink
docs(project): add support for the alex linter (#4396)
Browse files Browse the repository at this point in the history
* chore(project): add alex dependency

* chore(cli): add lint:docs task to ci-check

* docs(alex): fix content violations

* Update docs/guides/accessibility.md

* Update docs/guides/endgame.md

* chore(project): add alexignore file for generated sassdoc files
  • Loading branch information
joshblack authored and abbeyhrt committed Oct 28, 2019
1 parent 92a26fe commit d8187e6
Show file tree
Hide file tree
Showing 120 changed files with 871 additions and 70 deletions.
2 changes: 2 additions & 0 deletions .alexignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
# Ignore generated SassDoc files
**/docs/sass.md
Binary file added .yarn/offline-mirror/@sindresorhus-is-0.14.0.tgz
Binary file not shown.
Binary file not shown.
Binary file added .yarn/offline-mirror/alex-8.0.0.tgz
Binary file not shown.
Binary file added .yarn/offline-mirror/array-iterate-1.1.3.tgz
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file added .yarn/offline-mirror/cacheable-request-6.1.0.tgz
Binary file not shown.
Binary file added .yarn/offline-mirror/clone-response-1.0.2.tgz
Binary file not shown.
Binary file added .yarn/offline-mirror/configstore-4.0.0.tgz
Binary file not shown.
Binary file added .yarn/offline-mirror/cuss-1.17.0.tgz
Binary file not shown.
Binary file added .yarn/offline-mirror/debug-0.8.1.tgz
Binary file not shown.
Binary file added .yarn/offline-mirror/defer-to-connect-1.0.2.tgz
Binary file not shown.
Binary file added .yarn/offline-mirror/event-stream-3.1.7.tgz
Binary file not shown.
Binary file added .yarn/offline-mirror/figures-3.0.0.tgz
Binary file not shown.
Binary file added .yarn/offline-mirror/from-0.1.7.tgz
Binary file not shown.
Binary file added .yarn/offline-mirror/git-diff-tree-1.0.0.tgz
Binary file not shown.
Binary file added .yarn/offline-mirror/git-spawned-stream-0.1.1.tgz
Binary file not shown.
Binary file added .yarn/offline-mirror/got-9.6.0.tgz
Binary file not shown.
Binary file added .yarn/offline-mirror/has-yarn-2.1.0.tgz
Binary file not shown.
Binary file added .yarn/offline-mirror/hast-util-embedded-1.0.4.tgz
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file added .yarn/offline-mirror/hast-util-phrasing-1.0.4.tgz
Binary file not shown.
Binary file added .yarn/offline-mirror/hast-util-to-nlcst-1.2.6.tgz
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file added .yarn/offline-mirror/ignore-5.1.4.tgz
Binary file not shown.
Binary file added .yarn/offline-mirror/is-empty-1.2.0.tgz
Binary file not shown.
Binary file added .yarn/offline-mirror/is-hidden-1.1.2.tgz
Binary file not shown.
Binary file added .yarn/offline-mirror/is-npm-3.0.0.tgz
Binary file not shown.
Binary file added .yarn/offline-mirror/is-plain-obj-2.0.0.tgz
Binary file not shown.
Binary file added .yarn/offline-mirror/is-yarn-global-0.3.0.tgz
Binary file not shown.
Binary file added .yarn/offline-mirror/json-buffer-3.0.0.tgz
Binary file not shown.
Binary file added .yarn/offline-mirror/keyv-3.1.0.tgz
Binary file not shown.
Binary file added .yarn/offline-mirror/latest-version-5.1.0.tgz
Binary file not shown.
Binary file added .yarn/offline-mirror/limit-spawn-0.0.3.tgz
Binary file not shown.
Binary file added .yarn/offline-mirror/load-plugin-2.3.1.tgz
Binary file not shown.
Binary file not shown.
Binary file added .yarn/offline-mirror/lowercase-keys-2.0.0.tgz
Binary file not shown.
Binary file added .yarn/offline-mirror/map-stream-0.1.0.tgz
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file added .yarn/offline-mirror/nlcst-is-literal-1.2.0.tgz
Binary file not shown.
Binary file added .yarn/offline-mirror/nlcst-normalize-2.1.3.tgz
Binary file not shown.
Binary file added .yarn/offline-mirror/nlcst-search-1.5.1.tgz
Binary file not shown.
Binary file added .yarn/offline-mirror/nlcst-to-string-2.0.3.tgz
Binary file not shown.
Binary file added .yarn/offline-mirror/normalize-url-4.5.0.tgz
Binary file not shown.
Binary file added .yarn/offline-mirror/npm-prefix-1.2.0.tgz
Binary file not shown.
Binary file added .yarn/offline-mirror/object-keys-0.4.0.tgz
Binary file not shown.
Binary file added .yarn/offline-mirror/p-cancelable-1.1.0.tgz
Binary file not shown.
Binary file added .yarn/offline-mirror/package-json-6.5.0.tgz
Binary file not shown.
Binary file added .yarn/offline-mirror/parse-english-4.1.2.tgz
Binary file not shown.
Binary file added .yarn/offline-mirror/parse-latin-4.2.0.tgz
Binary file not shown.
Binary file added .yarn/offline-mirror/pause-stream-0.0.11.tgz
Binary file not shown.
Binary file added .yarn/offline-mirror/pluralize-8.0.0.tgz
Binary file not shown.
Binary file added .yarn/offline-mirror/prepend-http-2.0.0.tgz
Binary file not shown.
Binary file added .yarn/offline-mirror/pump-chain-1.0.0.tgz
Binary file not shown.
Binary file added .yarn/offline-mirror/quotation-1.1.2.tgz
Binary file not shown.
Binary file not shown.
Binary file added .yarn/offline-mirror/registry-url-5.1.0.tgz
Binary file not shown.
Binary file added .yarn/offline-mirror/rehype-retext-2.0.3.tgz
Binary file not shown.
Binary file not shown.
Binary file added .yarn/offline-mirror/remark-parse-7.0.1.tgz
Binary file not shown.
Binary file added .yarn/offline-mirror/remark-retext-3.1.3.tgz
Binary file not shown.
Binary file added .yarn/offline-mirror/responselike-1.0.2.tgz
Binary file not shown.
Binary file added .yarn/offline-mirror/retext-english-3.0.3.tgz
Binary file not shown.
Binary file added .yarn/offline-mirror/retext-equality-4.2.0.tgz
Binary file not shown.
Binary file added .yarn/offline-mirror/retext-profanities-5.0.0.tgz
Binary file not shown.
Binary file added .yarn/offline-mirror/shellsubstitute-1.2.0.tgz
Binary file not shown.
Binary file added .yarn/offline-mirror/sliced-1.0.1.tgz
Binary file not shown.
Binary file not shown.
Binary file added .yarn/offline-mirror/split-0.2.10.tgz
Binary file not shown.
Binary file not shown.
Binary file added .yarn/offline-mirror/stream-combiner-0.0.4.tgz
Binary file not shown.
Binary file added .yarn/offline-mirror/through2-0.4.2.tgz
Binary file not shown.
Binary file added .yarn/offline-mirror/to-readable-stream-1.0.0.tgz
Binary file not shown.
Binary file added .yarn/offline-mirror/to-vfile-6.0.0.tgz
Binary file not shown.
Binary file added .yarn/offline-mirror/unified-8.4.1.tgz
Binary file not shown.
Binary file added .yarn/offline-mirror/unified-diff-3.0.0.tgz
Binary file not shown.
Binary file added .yarn/offline-mirror/unified-engine-7.0.0.tgz
Binary file not shown.
Binary file not shown.
Binary file added .yarn/offline-mirror/unist-util-inspect-4.1.4.tgz
Binary file not shown.
Binary file added .yarn/offline-mirror/unist-util-is-4.0.0.tgz
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file added .yarn/offline-mirror/unist-util-visit-2.0.0.tgz
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file added .yarn/offline-mirror/untildify-2.1.0.tgz
Binary file not shown.
Binary file added .yarn/offline-mirror/update-notifier-3.0.1.tgz
Binary file not shown.
Binary file added .yarn/offline-mirror/url-parse-lax-3.0.0.tgz
Binary file not shown.
Binary file added .yarn/offline-mirror/vfile-find-up-5.0.0.tgz
Binary file not shown.
Binary file added .yarn/offline-mirror/vfile-reporter-6.0.0.tgz
Binary file not shown.
Binary file added .yarn/offline-mirror/vfile-sort-2.2.1.tgz
Binary file not shown.
Binary file added .yarn/offline-mirror/vfile-statistics-1.1.3.tgz
Binary file not shown.
Binary file added .yarn/offline-mirror/xtend-2.1.2.tgz
Binary file not shown.
16 changes: 10 additions & 6 deletions docs/developer-handbook.md
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,7 @@ _Parts of this section are duplicated from
[Angular's commit conventions](https://github.com/angular/angular/blob/master/CONTRIBUTING.md#-commit-message-guidelines)_.

Each commit message consists of a **header**, a **body** and a **footer**. The
header has a special format that includes a type, a scope and a subject:
header has a specific format that includes a type, a scope and a subject:

```git
<type>(<scope>): <subject>
Expand Down Expand Up @@ -259,10 +259,14 @@ The subject contains a succinct description of the change:

### Body

<!-- alex disable just -->

Just as in the subject, use the imperative, present tense: "change" not
"changed" nor "changes". The body should include the motivation for the change
and contrast this with previous behavior.

<!-- alex enable just -->

### Footer

The footer should contain any information about Breaking Changes.
Expand Down Expand Up @@ -496,8 +500,8 @@ There are two ways to define markups for components and their variants:

### Defining markup with no conditional or data interpolations

Defining markup with no conditional or data interpolation is as easy as adding a
`.hbs` file to the component directory. No `.config.js` file in the component
To define markup with no conditional or data interpolation you will need to add
a `.hbs` file to the component directory. No `.config.js` file in the component
directory is required in this case. One thing to note is that If there is a
`.hbs` file whose basename is exactly the same as the component name, other
`.hbs` files has to be in `componentname--variantname.hbs` format.
Expand Down Expand Up @@ -596,8 +600,8 @@ compile and update Storybook you can run the following command in the
yarn gulp watch -s
```

This will execute the `watch` command in `gulpfile.js`. As a result, whenever
you make a change to the project styles it will automatically copy over into the
This will run the `watch` command in `gulpfile.js`. As a result, whenever you
make a change to the project styles it will automatically copy over into the
`scss` folder which Storybook uses in `carbon-components-angular`.

### Pointing NPM dependency of `carbon-components` right to the source code
Expand Down Expand Up @@ -749,7 +753,7 @@ code at that point in time.

#### How do I install a dependency?

When installing a dependency, you can just do `yarn add <dependency-name>` as
When installing a dependency, you can run `yarn add <dependency-name>` as
normal. The only difference now is that you also will check in the corresponding
tarball entry in `.yarn/offline-mirror` as well so that we don't have to fetch
this dependency from the live registry during Continuous Integration builds.
Expand Down
16 changes: 11 additions & 5 deletions docs/guides/accessibility.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
<!-- alex disable failure -->

# Accessibility

<!-- prettier-ignore-start -->
Expand Down Expand Up @@ -73,8 +75,8 @@ positives when testing exclusively on a component. Typically we're not auditing
a webpage or a website as a whole, but a single component in isolation -- sadly
this was not DAP's intended purpose and so it throws a lot of false positive
violations that you'll first need to sift through and ignore if we're going to
be keeping and recording this audit. If you're just testing while you develop or
before you push a PR, feel free to just disregard them.
be keeping and recording this audit. If you're only testing while you develop or
before you push a PR, feel free to disregard them.

If the component fails or has a violation an issue should be made so that
someone can fix the problem. Feel free to include in the issue any relevant
Expand Down Expand Up @@ -148,13 +150,17 @@ using only your keyboard in the manner described. Integrating this test
throughout each stage of development will save you the pain of retro-fitting a
component with the necessary keyboard functionality.

### Screen Magnifier testing🔎
### Screen magnifier testing🔎

<!-- alex disable his -->

(Credit to Frederick Creemers
[excellent article](https://dev.to/_bigblind/how-to-make-your-website-accessible-to-people-who-use-a-screen-magnifier)
talking about his experience as a visually impaired screen magnification user on
the web.)

<!-- alex enable his -->

A user with a screen magnifier views web content on a component by component
basis through a 2x, 4x, or 8x (etc) zoomed in box. Two things become very
important when using a screen magnifier -- context and component permanence. We
Expand Down Expand Up @@ -205,10 +211,10 @@ consistency's sake we'll use DAP on the
Head over to the page and hit `cmd-option-c` to open up your dev tools. DAP is
tucked away inside a drop down menu inside a panel. From the default Elements
panel hit the >> icon below the X on the far right. You should see `DAP`. Click
that to fire up DAP for this page.
that to open up DAP for this page.

_Be Warned: You can only run DAP with internal IBM rulesets if you're connected
to W3. On an IBM campus this isn't a problem, but if you're abroad fire up the
to W3. On an IBM campus this isn't a problem, but if you're abroad open the
Cisco AnyConnect Secure Mobility Client._

Hit the play button and wait for the scan to finish. **We've got violations!**.
Expand Down
4 changes: 2 additions & 2 deletions docs/guides/building-an-icon-library.md
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ After you've received the green light, then you're ready to get started!
## Getting Started

The main package that exports all icon information is
[`@carbon/icons`](/packages/icons). This package hosts all of the source SVG
[`@carbon/icons`](/packages/icons). This package contains all of the source SVG
assets, in addition to exporting the following assets:

- Optimized SVG assets from source files
Expand All @@ -58,7 +58,7 @@ determining how to best architect their implementation:
`<Icon name="icon-name">` component given that we could not tree-shake
`@carbon/icons` descriptors
- A system could support `<Icon icon={descriptor} />`, however this would
require a user to install two dependencies versus just your icon library
require a user to install two dependencies versus only your icon library
- Minimize the amount of runtime logic that has to be run. As a result, prefer
generating markup statically from SVG data versus using the data at runtime to
build up the SVG markup
Expand Down
2 changes: 2 additions & 0 deletions docs/guides/colors.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
<!-- alex disable colors -->

# Colors

<!-- prettier-ignore-start -->
Expand Down
41 changes: 21 additions & 20 deletions docs/guides/endgame.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
<!-- alex disable black -->

# Endgame

<!-- prettier-ignore-start -->
Expand Down Expand Up @@ -472,9 +474,9 @@ already exist in the project. These updates are reserved for

4. Once that's done, you should create a Pull Request in Draft state and make
sure **not** to merge it. Our goal with the Pull Request is to do a final
sanity check for CI checks, verify preview links work as expected, and get
final reviews from the endgame team for the release. _Note: Make sure to
specify which packages are being updated for your reviewers._
check for CI checks, verify preview links work as expected, and get final
reviews from the endgame team for the release. _Note: Make sure to specify
which packages are being updated for your reviewers._
5. Once everything is green, review the pull request. Make sure there are no
commits labeled `feat` as the patch release should only be for bug fixes,
Expand All @@ -499,8 +501,7 @@ already exist in the project. These updates are reserved for
npm dist-tag add package-name@X.Y.Z latest
```
For example, if you just released `10.6.1` under `next`, this would look
like:
For example, if you released `10.6.1` under `next`, this would look like:
```bash
npm dist-tag add carbon-components@10.6.1 latest
Expand All @@ -509,10 +510,10 @@ already exist in the project. These updates are reserved for
8. Manually check to see that the `latest` tags were updated for the packages
correctly by going to [`npm`](https://www.npmjs.com), searching the packages,
viewing the versions and making sure the `latest` version matches the version
you just released.
you released.
9. After publishing to latest, create a tag for the version you just released
and push it to upstream by running:
9. After publishing to latest, create a tag for the version you released and
push it to upstream by running:
```bash
git tag -a vX.Y.Z -m "vX.Y.Z"
Expand Down Expand Up @@ -712,9 +713,9 @@ git commit -m 'chore(release): update package versions'
```
Once that's done, you should create a Pull Request in Draft state and make sure
**not** to merge it. Our goal with the Pull Request is to do a final sanity
check for CI checks, verify preview links work as expected, and get final
reviews from the endgame team for the release.
**not** to merge it. Our goal with the Pull Request is to do a check for CI
checks, verify preview links work as expected, and get final reviews from the
endgame team for the release.

Once everything is green and your Pull Request has been reviewed, you should
**close** the draft Pull Request. On your machine, you should then follow the
Expand All @@ -729,8 +730,8 @@ following steps to release:
- If everything looks good to go, then you should go through each of the
packages and add the `latest` tag using the command:
`npm dist-tag add package-name@X.Y.Z latest`
- After publishing to latest, create a tag for the version you just released and
push it to upstream by running:
- After publishing to latest, create a tag for the version you released and push
it to upstream by running:

```bash
git tag -a vX.Y.Z -m "vX.Y.Z"
Expand Down Expand Up @@ -769,7 +770,7 @@ following steps to release:
### Release candidate releases
​ Before our minor releases, we cut release candidates a week in advance to
sanity check our code. ​
check our code. ​
#### Publishing steps
Expand All @@ -794,7 +795,7 @@ sanity check our code. ​
6. Manually check to see that the `next` tag was updated for the packages
correctly by going to [`npm`](https://www.npmjs.com), searching the packages,
viewing the versions and making sure the `next` version matches the version
you just released.
you released.
### Minor releases
Expand Down Expand Up @@ -832,7 +833,7 @@ can be released on-demand in specific circumstances.
3. After the package versions have been created, you'll be prompted
`The next step will be to manually create a Pull Request for this branch`.
Simply push your changes and open the PR. Be sure your commit message reads
Push your changes and open the PR. Be sure your commit message reads
`chore(release): update package versions`
4. Once your PR is approved and merged, checkout `master`, pull the latest
upstream and run:
Expand All @@ -853,7 +854,7 @@ can be released on-demand in specific circumstances.
7. Manually check to see that the `next` tag was updated for the packages
correctly by going to [`npm`](https://www.npmjs.com), searching the packages,
viewing the versions and making sure the `next` version matches the version
you just released.
you released.
8. When you're ready to update `latest`, run
`npm dist-tag add package-name@X.Y.Z latest` for each of the updated
Expand All @@ -876,10 +877,10 @@ can be released on-demand in specific circumstances.
9. Like before, manually check to see that the `latest` tags were updated for
the packages correctly by going to [`npm`](https://www.npmjs.com), searching
the packages, viewing the versions and making sure the `latest` version
matches the version you just released.
matches the version you released.
10. After publishing to latest, create a tag for the version you just released
and push it to upstream by running:
10. After publishing to latest, create a tag for the version you released and
push it to upstream by running:
```bash
git tag -a vX.Y.Z -m "vX.Y.Z"
Expand Down
3 changes: 1 addition & 2 deletions docs/guides/ibm-plex.md
Original file line number Diff line number Diff line change
Expand Up @@ -104,8 +104,7 @@ The following are the options for each of these sub-paths:
- `Latin3`
- `Pi`

To get the hang of things, let's go through a couple of examples for various
font families and formats.
Let's go through a couple of examples for various font families and formats.

<details>
<summary>IBM Plex Arabic</summary>
Expand Down
2 changes: 2 additions & 0 deletions docs/guides/sass.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
<!-- alex disable color -->

# Sass

<!-- prettier-ignore-start -->
Expand Down
4 changes: 3 additions & 1 deletion docs/guides/setup/design.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
<!-- alex disable color -->

# Design

<!-- prettier-ignore-start -->
Expand Down Expand Up @@ -27,7 +29,7 @@
## Intro

If you’re a designer looking to contribute, thanks so much for taking the time
to learn. We really appreciate it! We also want to make it as easy as possible
to learn. We really appreciate it! We also want to make it as simple as possible
for you, so if you have any suggestions for improving this guide please let us
know!

Expand Down
2 changes: 1 addition & 1 deletion docs/guides/setup/windows.md
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ but can be unexpected.
- `sudo umount /mnt/c`
- `sudo mount -t drvfs C: /mnt/c -o metadata`
12. Change directories into your projects folder
`cd /mnt/c/Users/{username}/projects` (Just an example, use whatever you'd
`cd /mnt/c/Users/{username}/projects` (Only an example, use whatever you'd
like)
13. Clone our repo
`git clone https://github.com/carbon-design-system/carbon.git`
Expand Down
2 changes: 1 addition & 1 deletion docs/guides/so-you're-going-on-vacation.md
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,6 @@ you get back!
- [ ] Delegate Pull Requests or Issue conversations that you're actively engaged
in

If you're on the hook for a review, or are actively engaging in an issue, make
If you're responsible for a review, or are actively engaging in an issue, make
sure to find an appropriate delegate while you're out so work isn't being
blocked.
10 changes: 6 additions & 4 deletions docs/guides/support.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
<!-- alex disable failures -->

# Carbon core support and maintenance

<!-- prettier-ignore-start -->
Expand Down Expand Up @@ -58,7 +60,7 @@ ask them to do so. Typically you'll need at least a good description of the
problem, a walkthrough of how to recreate the problem and a minimal test case to
observe the problem happening. That last one can be a real sticking point, but
there's lots of work to do and many many issues to triage — the onus is on them
to clearly define the issue their having._
to define the issue their having._

### Types of issues

Expand Down Expand Up @@ -140,7 +142,7 @@ future no label is needed because the issue should be closed)_.

### Other labels

There are a whole host of labels that can help communicate the nature of an
There is a large collection of labels that can help communicate the nature of an
issue at a glance to developers and designers. Here's a few that you might add
that can be particularly helpful:

Expand All @@ -165,8 +167,8 @@ can alert specific sub-teams on Carbon:

Using any of these @'s in a comment will send notifications to members of those
sub-teams. Typically a subject matter expert from that team will then take over.
You can also just @username anyone Carbon's team if you specifically know
someone who has experience with a particular component or issue.
You can also @username anyone Carbon's team if you specifically know someone who
has experience with a particular component or issue.

## Pull requests

Expand Down
2 changes: 2 additions & 0 deletions docs/migration/10.x-color.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
<!-- alex disable color -->

# Colors

<!-- prettier-ignore-start -->
Expand Down
2 changes: 2 additions & 0 deletions docs/migration/10.x-themes.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
<!-- alex disable color -->

# Themes

<!-- prettier-ignore-start -->
Expand Down
6 changes: 4 additions & 2 deletions docs/on-windows-hcm-support.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
<!-- alex disable colors -->

<!-- START doctoc generated TOC please keep comment here to allow auto update -->
<!-- DON'T EDIT THIS SECTION, INSTEAD RE-RUN doctoc TO UPDATE -->

Expand Down Expand Up @@ -46,8 +48,8 @@ affordance enabled.

### Edge/Internet Explorer

Microsoft's browsers Edge and Internet Explorer obviously have ideal support for
WHCM applying a users chosen theme wholesale to the web content and allowing
Microsoft's browsers Edge and Internet Explorer have ideal support for WHCM
applying a users chosen theme wholesale to the web content and allowing
developers to target problematic CSS generated graphics or SVGs via their
extension and set safe fallbacks using CSS system colors.

Expand Down
4 changes: 3 additions & 1 deletion docs/postmortems/2019-08-15-icons-angular.md
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ there was no prompt in the GitHub UI for a final review from the

Since `v10.5.0` was recently released, we decided to use the `unpublish` feature
of `npm` that is valid within 72hours of a release. Running this command
subsequently unpublished the invalid build of `@carbon/icons-angular` and
subsequently unpublished the broken build of `@carbon/icons-angular` and
restored `v10.4.0` as the `latest` package for teams to consume.

**Detection**
Expand All @@ -60,6 +60,8 @@ This issue was first reported by @cal-smith

**Where we got lucky**

<!-- alex disable period -->

- We were still within the 72 hour time period required by `npm` for their
`unpublish` feature to work

Expand Down
Loading

0 comments on commit d8187e6

Please sign in to comment.