fix(FileUploader): remove invalid default role value

carbon-design-system · Oct 4, 2019 · c916b74 · c916b74
1 parent 73f7bde
commit c916b74
Show file tree

Hide file tree

Showing 4 changed files with 1 addition and 7 deletions.
diff --git a/packages/react/src/components/FileUploader/FileUploader-story.js b/packages/react/src/components/FileUploader/FileUploader-story.js
@@ -104,7 +104,6 @@ const props = {
       ','
     ),
     disabled: boolean('Disabled (disabled)', false),
-    role: text('ARIA role of the button (role)', ''),
     tabIndex: number('Tab index (tabIndex)', 0),
     onChange: action('onChange'),
   }),

diff --git a/packages/react/src/components/FileUploader/FileUploader-test.js b/packages/react/src/components/FileUploader/FileUploader-test.js
@@ -132,10 +132,6 @@ describe('FileUploaderButton', () => {
       expect(wrapper.find('input').prop('disabled')).toEqual(true);
     });
 
-    it('does have default role', () => {
-      expect(mountWrapper.props().role).toBeTruthy();
-    });
-
     it('resets the input value onClick', () => {
       const input = mountWrapper.find(`.${prefix}--visually-hidden`);
       input.instance().value = '';

diff --git a/packages/react/src/components/FileUploader/FileUploader.js b/packages/react/src/components/FileUploader/FileUploader.js
@@ -111,7 +111,6 @@ export class FileUploaderButton extends Component {
     onClick: () => {},
     accept: [],
     disabled: false,
-    role: 'button',
   };
 
   static getDerivedStateFromProps({ labelText }, state) {

diff --git a/packages/react/src/components/FileUploader/FileUploaderDropContainer.js b/packages/react/src/components/FileUploader/FileUploaderDropContainer.js
@@ -98,7 +98,7 @@ export default function FileUploaderDropContainer(props) {
       <label
         className={labelClasses}
         htmlFor={id || uid.current}
-        role={role || 'button'}
+        role={role}
         tabIndex={tabIndex || 0}
         onKeyDown={evt => {
           if (matches(evt, [keys.Enter, keys.Space])) {