Skip to content

Commit

Permalink
Fix typos in e2e / translation docs (#14685)
Browse files Browse the repository at this point in the history
* docs(testing): fix typos in testing docs

* docs(style): fix typos in style docs wrt translation
  • Loading branch information
m4olivei authored Sep 20, 2023
1 parent df04546 commit 8932ef8
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 8 deletions.
8 changes: 5 additions & 3 deletions docs/style.md
Original file line number Diff line number Diff line change
Expand Up @@ -439,10 +439,12 @@ function MyComponent({ translateWithId: t = translateWithId }) {

return (
<>
<span>The current count is:
{t('carbon.component-name.display-count'), translationState}</span>
<span>
The current count is:
{t('carbon.component-name.display-count', translationState)}
</span>
<button onClick={() => updateCount(count + 1)}>
{t('carbon.component-name.increment-count')}</span>
{t('carbon.component-name.increment-count')}
</button>
</>
);
Expand Down
10 changes: 5 additions & 5 deletions docs/testing.md
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ cd packages/react
yarn storybook
```

One the storybook is loaded, you can run tests against is using the storybook
Once the storybook is loaded, you can run tests against it using the storybook
test-utils found in `e2e/test-utils/storybook`. A common use-case for testing a
component is to use Percy to take a snapshot of a component in a particular
theme from a specific story in storybook.
Expand Down Expand Up @@ -122,7 +122,7 @@ against.
#### Working with snapshots locally

Sometimes you'll want to debug snapshots locally instead of relying on an
externaly service to get feedback. To do so, you can use the
external service to get feedback. To do so, you can use the
`ENABLE_LOCAL_SNAPSHOTS` environment variable to store snapshots locally. Almost
any playwright command you run can be prefixed with this value in order to store
screenshots locally.
Expand All @@ -137,13 +137,13 @@ screenshots locally**
The first time you'll run this command, it will need to generate the baseline
snapshots for this component. The second time you run it, it will compare the
snapshots for the current page with what is stored in the screenshot. If the two
do not match, playwright will report a failure and will provide a link to the
do not match, Playwright will report a failure and will provide a link to the
diff image on your machine.

## FAQ

### Why am I seeing `browserType.launch: Executable doesn't exist at ../path`?

The browser executables need to be installed so that playwright can run tests
inside chromium, firefox, etc. They can be installed by running
The browser executables need to be installed so that Playwright can run tests
inside Chromium, Firefox, etc. They can be installed by running
`yarn playwright install`

0 comments on commit 8932ef8

Please sign in to comment.