Skip to content

Commit

Permalink
fix(dropdown): fix inline field height not adapting to prop size chan…
Browse files Browse the repository at this point in the history
…ge (#5988)

* fix(dropdown): removed default height of inline list box and drop-down

* fix(dropdown): updated the docs

Co-authored-by: TJ Egan <tw15egan@gmail.com>
Co-authored-by: Akira Sudoh <asudoh@gmail.com>
  • Loading branch information
3 people authored May 4, 2020
1 parent d22b9b2 commit 6be11cc
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 14 deletions.
7 changes: 0 additions & 7 deletions packages/components/docs/sass.md
Original file line number Diff line number Diff line change
Expand Up @@ -17608,7 +17608,6 @@ Dropdown styles
display: inline-block;
border-bottom-color: transparent;
width: auto;
height: rem(32px);
background-color: transparent;
transition: background $duration--fast-01 motion(entrance, productive);

Expand Down Expand Up @@ -18734,12 +18733,6 @@ List box styles
background-color: $field-02;
}

.#{$prefix}--list-box.#{$prefix}--list-box--inline,
.#{$prefix}--list-box.#{$prefix}--list-box--inline
.#{$prefix}--list-box__field {
height: rem(32px);
}

.#{$prefix}--list-box.#{$prefix}--list-box--inline
.#{$prefix}--list-box__field {
padding: 0 carbon--mini-units(4) 0 $carbon--spacing-03;
Expand Down
1 change: 0 additions & 1 deletion packages/components/src/components/dropdown/_dropdown.scss
Original file line number Diff line number Diff line change
Expand Up @@ -350,7 +350,6 @@
display: inline-block;
border-bottom-color: transparent;
width: auto;
height: rem(32px);
background-color: transparent;
transition: background $duration--fast-01 motion(entrance, productive);

Expand Down
6 changes: 0 additions & 6 deletions packages/components/src/components/list-box/_list-box.scss
Original file line number Diff line number Diff line change
Expand Up @@ -229,12 +229,6 @@ $list-box-menu-width: rem(300px);
background-color: $field-02;
}

.#{$prefix}--list-box.#{$prefix}--list-box--inline,
.#{$prefix}--list-box.#{$prefix}--list-box--inline
.#{$prefix}--list-box__field {
height: rem(32px);
}

.#{$prefix}--list-box.#{$prefix}--list-box--inline
.#{$prefix}--list-box__field {
padding: 0 carbon--mini-units(4) 0 $carbon--spacing-03;
Expand Down

0 comments on commit 6be11cc

Please sign in to comment.