Skip to content

Commit

Permalink
refactor(MultiSelect): add typescript annotations
Browse files Browse the repository at this point in the history
Convert existing propType definitions to Typescript annotations on the
MultiSelect component. This is part of a broader effort to add
Typescript annotations to components, tracked in carbon-design-system#12513.
Closes carbon-design-system#12547.

Only type annotations, no breaking feature changes
  • Loading branch information
awarrier99 committed Feb 13, 2023
1 parent ed60d32 commit 2e58fa5
Show file tree
Hide file tree
Showing 5 changed files with 277 additions and 39 deletions.
9 changes: 9 additions & 0 deletions .all-contributorsrc
Original file line number Diff line number Diff line change
Expand Up @@ -1013,6 +1013,15 @@
"contributions": [
"code"
]
},
{
"login": "awarrier99",
"name": "Ashvin Warrier",
"avatar_url": "https://avatars.githubusercontent.com/u/17476235?v=4",
"profile": "https://github.com/awarrier99",
"contributions": [
"code"
]
}
],
"commitConvention": "none"
Expand Down
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -216,6 +216,7 @@ check out our [Contributing Guide](/.github/CONTRIBUTING.md) and our
<td align="center"><a href="https://github.com/jpsorensen"><img src="https://avatars.githubusercontent.com/u/93107699?v=4?s=100" width="100px;" alt=""/><br /><sub><b>jpsorensen</b></sub></a><br /><a href="https://github.com/carbon-design-system/carbon/commits?author=jpsorensen" title="Code">💻</a></td>
<td align="center"><a href="https://github.com/jkap"><img src="https://avatars.githubusercontent.com/u/224587?v=4?s=100" width="100px;" alt=""/><br /><sub><b>jae kaplan</b></sub></a><br /><a href="#infra-jkap" title="Infrastructure (Hosting, Build-Tools, etc)">🚇</a></td>
<td align="center"><a href="https://github.com/sierrawetmore"><img src="https://avatars.githubusercontent.com/u/107062203?v=4?s=100" width="100px;" alt=""/><br /><sub><b>Sierra Wetmore</b></sub></a><br /><a href="https://github.com/carbon-design-system/carbon/commits?author=sierrawetmore" title="Code">💻</a></td>
<td align="center"><a href="https://github.com/awarrier99"><img src="https://avatars.githubusercontent.com/u/17476235?v=4?s=100" width="100px;" alt=""/><br /><sub><b>Ashvin Warrier</b></sub></a><br /><a href="https://github.com/carbon-design-system/carbon/commits?author=awarrier99" title="Code">💻</a></td>
</tr>
</table>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -232,6 +232,7 @@ export const WithInitialSelectedItems = () => {
return (
<div style={{ width: 300 }}>
<MultiSelect
label="Multiselect Label"
id="carbon-multiselect-example-2"
titleText="Multiselect title"
helperText="This is helper text"
Expand Down
Loading

0 comments on commit 2e58fa5

Please sign in to comment.