fix(FileUploader): move role attribute to valid element

carbon-design-system · Oct 7, 2019 · 0350748 · 0350748
1 parent dd2c135
commit 0350748
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/packages/react/src/components/FileUploader/FileUploader.js b/packages/react/src/components/FileUploader/FileUploader.js
@@ -175,9 +175,8 @@ export class FileUploaderButton extends Component {
             }
           }}
           htmlFor={this.uid}
-          role={role}
           {...other}>
-          {this.state.labelText}
+          <span role={role}>{this.state.labelText}</span>
         </label>
         <input
           className={`${prefix}--visually-hidden`}

diff --git a/packages/react/src/components/FileUploader/FileUploaderDropContainer.js b/packages/react/src/components/FileUploader/FileUploaderDropContainer.js
@@ -98,15 +98,14 @@ export default function FileUploaderDropContainer(props) {
       <label
         className={labelClasses}
         htmlFor={id || uid.current}
-        role={role || 'button'}
         tabIndex={tabIndex || 0}
         onKeyDown={evt => {
           if (matches(evt, [keys.Enter, keys.Space])) {
             inputRef.current.click();
           }
         }}
         {...other}>
-        <div className={dropareaClasses}>
+        <div className={dropareaClasses} role={role || 'button'}>
           {labelText}
           <input
             type="file"