-
Notifications
You must be signed in to change notification settings - Fork 795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Button guidance PR #4409
Open
alina-jacob
wants to merge
14
commits into
carbon-design-system:main
Choose a base branch
from
alina-jacob:button_pr
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Button guidance PR #4409
Changes from 7 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
390274a
button_pr
alina-jacob-ibm 7fecafe
chore: yarn format
alisonjoseph a66a661
fix: update icon to StopOutline
alisonjoseph df020bc
chore: encode characters
alisonjoseph a93f016
update_1
alina-jacob-ibm 6505681
Merge branch 'main' into button_pr
alina-jacob 6ad3f5f
chore:format
alisonjoseph 1b0bceb
update_2
alina-jacob-ibm 8bfb956
chore(prettier): format code
kennylam a983a7f
update_3
alina-jacob-ibm 2cfc4e2
Merge branch 'main' into button_pr
alina-jacob 9a8d203
:chore: format
alisonjoseph 1e40a82
update_4
alina-jacob-ibm eb6b939
Merge branch 'main' into button_pr
aagonzales File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Binary file added
BIN
+11.3 KB
...pages/components/button/images/button-style-danger-ghost-interactive-states.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-14.6 KB
(29%)
src/pages/components/button/images/button-style-danger-ghost.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+11.4 KB
...ges/components/button/images/button-style-danger-primary-interactive-states.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+11.4 KB
...es/components/button/images/button-style-danger-tertiary-interactive-states.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-15.2 KB
(28%)
src/pages/components/button/images/button-style-danger-tertiary.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file not shown.
Binary file removed
BIN
-21.4 KB
src/pages/components/button/images/button-style-ghost+icon-only.png
Binary file not shown.
Binary file added
BIN
+5.7 KB
...es/components/button/images/button-style-ghost-icon-only-interactive-states.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+10.9 KB
src/pages/components/button/images/button-style-ghost-interactive-states.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-8.65 KB
(40%)
src/pages/components/button/images/button-style-ghost.png
100755 → 100644
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+5.68 KB
.../components/button/images/button-style-primary-icon-only-interactive-states.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+4.34 KB
src/pages/components/button/images/button-style-primary-icon-only.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+11 KB
src/pages/components/button/images/button-style-primary-interactive-states.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-8.45 KB
(40%)
src/pages/components/button/images/button-style-primary.png
100755 → 100644
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+5.68 KB
...omponents/button/images/button-style-secondary-icon-only-interactive-states.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+4.34 KB
src/pages/components/button/images/button-style-secondary-icon-only.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+10.4 KB
src/pages/components/button/images/button-style-secondary-interactive-states.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-2.08 KB
(73%)
src/pages/components/button/images/button-style-secondary.png
100755 → 100644
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+34.1 KB
src/pages/components/button/images/button-style-structure-button-groups.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-14.7 KB
(52%)
src/pages/components/button/images/button-style-structure.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+5.7 KB
...components/button/images/button-style-tertiary-icon-only-interactive-states.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+4.35 KB
src/pages/components/button/images/button-style-tertiary-icon-only.png
Oops, something went wrong.
Binary file added
BIN
+11 KB
src/pages/components/button/images/button-style-tertiary-interactive-states.png
Oops, something went wrong.
Binary file modified
BIN
-8.44 KB
(40%)
src/pages/components/button/images/button-style-tertiary.png
100755 → 100644
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Diff not rendered.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Diff not rendered.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Diff not rendered.
Diff not rendered.
Oops, something went wrong.
Oops, something went wrong.
Diff not rendered.
Oops, something went wrong.
Diff not rendered.
Oops, something went wrong.
Diff not rendered.
Binary file added
BIN
+13.6 KB
src/pages/components/button/images/button_usage_button_with_icon_1.png
Oops, something went wrong.
Binary file added
BIN
+9.5 KB
src/pages/components/button/images/button_usage_button_with_icon_10.png
Oops, something went wrong.
Binary file added
BIN
+9.91 KB
src/pages/components/button/images/button_usage_button_with_icon_11.png
Oops, something went wrong.
Binary file added
BIN
+3.85 KB
src/pages/components/button/images/button_usage_button_with_icon_12.png
Oops, something went wrong.
Binary file added
BIN
+5.27 KB
src/pages/components/button/images/button_usage_button_with_icon_13.png
Oops, something went wrong.
Binary file added
BIN
+13.5 KB
src/pages/components/button/images/button_usage_button_with_icon_2.png
Oops, something went wrong.
Binary file added
BIN
+8.03 KB
src/pages/components/button/images/button_usage_button_with_icon_3.png
Oops, something went wrong.
Binary file added
BIN
+8.08 KB
src/pages/components/button/images/button_usage_button_with_icon_4.png
Oops, something went wrong.
Binary file added
BIN
+17.8 KB
src/pages/components/button/images/button_usage_button_with_icon_5.png
Oops, something went wrong.
Binary file added
BIN
+18.7 KB
src/pages/components/button/images/button_usage_button_with_icon_6.png
Oops, something went wrong.
Binary file added
BIN
+70.3 KB
src/pages/components/button/images/button_usage_button_with_icon_7.png
Oops, something went wrong.
Binary file added
BIN
+8.84 KB
src/pages/components/button/images/button_usage_button_with_icon_8.png
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Binary file added
BIN
+31.7 KB
src/pages/components/button/images/button_usage_icon_only_button_1.png
Oops, something went wrong.
Binary file added
BIN
+24.8 KB
src/pages/components/button/images/button_usage_icon_only_button_2.png
Oops, something went wrong.
Binary file added
BIN
+11.6 KB
src/pages/components/button/images/button_usage_icon_only_button_3.png
Oops, something went wrong.
Binary file added
BIN
+11.6 KB
src/pages/components/button/images/button_usage_icon_only_button_4.png
Oops, something went wrong.
Binary file added
BIN
+10.6 KB
src/pages/components/button/images/button_usage_icon_only_button_5.png
Oops, something went wrong.
Binary file added
BIN
+9.53 KB
src/pages/components/button/images/button_usage_icon_only_button_6.png
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The overlay of this button looks off. Maybe try it with the multiply effect.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While creating this image, I was referring to the Menu buttons image where Thy has used a
Magenta 30overlay.Referring to AI label and Tag, it uses
Magenta 20as an underlay and overlay respectively.I won't be able to use an underlay for button, so doing an overlay with Magenta 20 (L-new) vs 30 (R-as is) for comparison, any preference? Magenta 20 looks better IMO!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, multiply doesn’t seem to be working in this situation since the button blue is much higher contrast than our usual components where we overlay this color. I was unable to find your actual image in your file and I could not replicate an "Overlay" blend mode at Magenta 20 to get the result you are showing. But Magenta 30, @80% looks pretty similar to it.
In the production guidelines for dark themes in these highlight situations, Jeannie specified using opacity instead of multiply. Maybe we could use an opacity here and just use a lighter or darker magenta step color?
Here are some options below, if you go anywhere lighter or darker than these either in opacity or color step it starts to get weird.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The most accessible among these options (from a color contrast perspective) is the last option which is Magenta 40 at 60% opacity. Shall I proceed with that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we use a tertiary button here instead of a primary? That might help with clarity. But I do like the Magenta 40 @60% that works fine IMO. Could maybe also add a border? Either way I think you can just pick an option @alina-jacob and we can be done with this one. Its an odd ball.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tertiary button idea is great, so I can do that!
I'll refer the AI label for specs.
Thanks guys!