Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(fluid-inputs): update branch with latest changes from main #3202

Merged
merged 35 commits into from
Oct 14, 2022
Merged
Changes from 1 commit
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
a6bf633
chore(release): update carbon deps (#3159)
carbon-automation[bot] Sep 16, 2022
6b5e381
feat(website): add accessibility link, update common js (#3155)
tay1orjones Sep 16, 2022
2cf9d87
fix: mdx formatting inside component demo (#3160)
alisonjoseph Sep 16, 2022
835651e
docs: contained-list (#3145)
laurenmrice Sep 16, 2022
00c3c22
docs(grid): updated with API docs and example (#3136)
sstrubberg Sep 16, 2022
75d038d
fix(typography): fix controls bug (#3130)
aledavila Sep 19, 2022
e0059b2
Updated outdated links to storybook (#3164)
aagonzales Sep 20, 2022
94d7e1e
Change tab text of typography from "Styling strategies" to "Style str…
abhilipsasahoo03 Sep 20, 2022
1821a88
Update accessibility.mdx (#3143)
mbgower Sep 21, 2022
7ea3965
Correct verbiage on ibm commerce platform page (#3157)
francinelucca Sep 21, 2022
34f3b22
Compressed Images (#3162)
github-actions[bot] Sep 23, 2022
85db97a
docs(Theme): update Theme docs with new guidance/usage (#2998)
dakahn Sep 26, 2022
cf56acd
docs(team): removed team page and removed photos from partners (#3170)
sstrubberg Sep 26, 2022
0cc48b8
fix(content): broken links (#3167)
alisonjoseph Sep 27, 2022
62338df
docs(meetups): added office hours) (#3165)
sstrubberg Sep 27, 2022
b3416d2
update dataviz meeting time (#3177)
theiliad Sep 28, 2022
8b0bafa
chore(release): update carbon deps (#3178)
carbon-automation[bot] Sep 30, 2022
30d826f
docs: figma v11 release content updates (#3176)
laurenmrice Sep 30, 2022
d6d2b50
Compressed Images (#3184)
github-actions[bot] Oct 3, 2022
5d881e4
docs(Accordion): match Accordion to ken to code (#3180)
tw15egan Oct 4, 2022
f2ff211
Ecosystem updates (#3150)
mzuliani-ibm Oct 4, 2022
a3326c0
feat: add crosslink banner to carbon platform on homepage (#3185)
alisonjoseph Oct 5, 2022
4f6b0ab
docs: add flush accordion content (#3168)
laurenmrice Oct 5, 2022
fee6747
docs(progress-bar): add component live demo (#3182)
janhassel Oct 6, 2022
e280be0
docs(svelte): update resources and intro (#3183)
metonym Oct 7, 2022
b6ebe8e
Compressed Images (#3189)
github-actions[bot] Oct 11, 2022
5a8054e
docs(contact-us): minor updates to contact us page (#3186)
jeffchew Oct 12, 2022
e9bb1ba
chore(release): update carbon deps (#3194)
carbon-automation[bot] Oct 12, 2022
8591c2d
fix(tutorial): remove optimize sass from step 5 (#3192)
tay1orjones Oct 13, 2022
a06adb9
refactor(tutorial): remove badging (#3197)
tay1orjones Oct 13, 2022
9cffd78
chore(release): update carbon deps (#3200)
carbon-automation[bot] Oct 13, 2022
c73744d
fix(Icons): fix broken link (#3196)
tw15egan Oct 14, 2022
3c128a6
docs(Fluid inputs): text input and text area (#3158)
aagonzales Oct 4, 2022
7e5d681
chore(format): run yarn format
tw15egan Oct 14, 2022
77d20c7
Merge branch 'carbon-design-system:fluid-inputs' into fluid-inputs
tw15egan Oct 14, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix(tutorial): remove optimize sass from step 5 (#3192)
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
  • Loading branch information
tay1orjones and kodiakhq[bot] authored Oct 13, 2022
commit 8591c2da595e5db1795ed87741913e11a3756dc0
54 changes: 0 additions & 54 deletions src/pages/developing/react-tutorial/step-5.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -110,60 +110,6 @@ Before we get started,
[create an IBM Cloud account](https://cloud.ibm.com/registration) if you don't
already have one, as we'll be deploying there in a bit.

## Optimize Sass

So far we've been developing in a, well, development environment where static
asset optimization hasn't been a priority. If you reference `/src/index.scss`,
you'll see one `@import` that is pulling in Carbon's full Sass build.

```scss path=src/index.scss
$feature-flags: (
grid-columns-16: true,
);

@import 'carbon-components/scss/globals/scss/styles.scss';
```

To give you an idea of what's all included, open up
`node_modules/carbon-components/scss/globals/scss/styles.scss`. You'll see
imports for components like accordion, slider, tooltip, etc. Since we aren't
using those components, let's exclude them from our built stylesheets. Keeping
the `$feature-flags` Sass map, replace the `styles.scss` import with:

```scss path=src/index.scss
// Feature flags
$css--font-face: true;
$css--plex: true;

// Global styles
@import 'carbon-components/scss/globals/scss/css--font-face';
@import 'carbon-components/scss/globals/grid/grid';

// Carbon components
@import 'carbon-components/scss/components/breadcrumb/breadcrumb';
@import 'carbon-components/scss/components/button/button';
@import 'carbon-components/scss/components/data-table/data-table';
@import 'carbon-components/scss/components/link/link';
@import 'carbon-components/scss/components/pagination/pagination';
@import 'carbon-components/scss/components/tabs/tabs';
@import 'carbon-components/scss/components/ui-shell/ui-shell';
```

In comparing to the included `carbon-components/scss/globals/scss/styles.scss`,
you may be asking what happened to importing `_vars.scss`, `_colors.scss`,
`_theme.scss`, etc.?

Many of those global Sass partials get imported through the components. For
example, open
`node_modules/carbon-components/scss/components/button/_button.scss` to see its
dependencies. No harm in importing them as
`carbon-components/scss/globals/scss/styles.scss` does, but for simplicity here,
we'll let the components pull them in.

You can read more about optimizing Carbon's Sass in the
[Carbon Design System publication](https://medium.com/carbondesign/minimal-css-with-carbon-b0c089ccfa71)
on Medium.

## Build for production

Before we deploy our app, we need to create an optimized production build with
Expand Down