Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(notification): remove invalid migration note #2870

Merged

Conversation

tay1orjones
Copy link
Member

Refs carbon-design-system/carbon#11172

Reported on slack, I missed a spot on the notification docs.

Changelog

Removed

  • Remove docs stating the title and subtitle props have been removed, they were not removed in v11.

@tay1orjones tay1orjones requested review from a team as code owners April 7, 2022 15:22
@vercel
Copy link

vercel bot commented Apr 7, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/carbon-design-system/carbondesignsystem/Bz7MUrBAqfbZCZ8Pm4RNfuiZeFAA
✅ Preview: https://carbondesignsystem-git-fork-tay1orj-0ebbda-carbon-design-system.vercel.app

@jnm2377
Copy link
Contributor

jnm2377 commented Apr 7, 2022

@tay1orjones I thought we did remove them though? I remember having to migrate notifications bc those props no longer worked, and they had to be children going forward. Did we change that at some point?

Here's one example: carbon-design-system/carbon#10674

Screen Shot 2022-04-07 at 12 54 42 PM

@tay1orjones
Copy link
Member Author

@jnm2377 yeah it was a last-minute reversal before v11 dropped to add them back in: carbon-design-system/carbon#11022

Copy link
Contributor

@aledavila aledavila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@kodiakhq kodiakhq bot merged commit bb87b0a into carbon-design-system:main Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants