Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add on demand and scheduled image processing #2140

Merged
merged 1 commit into from
Feb 15, 2021

Conversation

vpicone
Copy link
Contributor

@vpicone vpicone commented Feb 12, 2021

This updates the image processing to allow for running on-demand and scheduled (once a week on Sunday). This prevents the bot from cluttering (sometimes unrelated) pull requests, which has been a source of confusion during code reviews.

After manually triggering the action in a fork, the bot successfully opened a PR shaving off 10mb from the images.

Changed

  • update image processing action configuration

This updates the image processing to allow for running on-demand and scheduled (once a week on Sunday). This prevents the bot from cluttering (sometimes unrelated) pull requests, which has been a source of confusion during code reviews.

After manually triggering the action in a fork, the bot successfully opened a PR shaving off 10mb from the images.
@vpicone vpicone requested a review from a team as a code owner February 12, 2021 21:41
@vpicone vpicone requested review from joshblack and emyarod February 12, 2021 21:41
@vercel
Copy link

vercel bot commented Feb 12, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/carbon-design-system/carbondesignsystem/7x76kttn1
✅ Preview: https://carbondesignsystem-git-vpicone-image-processing.carbon-design-system.vercel.app

Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@kodiakhq kodiakhq bot merged commit d98a90b into master Feb 15, 2021
@kodiakhq kodiakhq bot deleted the vpicone-image-processing branch February 15, 2021 19:02
natashadecoste pushed a commit to natashadecoste/carbon-website that referenced this pull request May 19, 2021
…tem#2140)

This updates the image processing to allow for running on-demand and scheduled (once a week on Sunday). This prevents the bot from cluttering (sometimes unrelated) pull requests, which has been a source of confusion during code reviews.

After manually triggering the action in a fork, the bot successfully opened a PR shaving off 10mb from the images.
natashadecoste pushed a commit to natashadecoste/carbon-website that referenced this pull request May 19, 2021
…tem#2140)

This updates the image processing to allow for running on-demand and scheduled (once a week on Sunday). This prevents the bot from cluttering (sometimes unrelated) pull requests, which has been a source of confusion during code reviews.

After manually triggering the action in a fork, the bot successfully opened a PR shaving off 10mb from the images.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants