Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(index): add images and update entries #1570

Merged

Conversation

joshblack
Copy link
Contributor

This PR adds in the initial batch of images and sets up the integration for images inside of the component index.

It also addresses some issues I ran into while implementing, namely:

  • There was a delay when searching when rendering the whole list that we ran into
  • There were some prop type warnings that appeared in console

Changelog

New

  • Add support for images in component index

Changed

  • Update schema for the metadata of icons to include images
  • Update how we render each tile to conditionally render entries
  • Update index list to include images
  • Update how we do search from an effect to doing it in render

Removed

@joshblack joshblack requested a review from a team as a code owner August 13, 2020 18:21
@joshblack joshblack requested review from tw15egan and dakahn August 13, 2020 18:21
@vercel
Copy link

vercel bot commented Aug 13, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click on the icon next to each commit.

carbon-website – ./

🔍 Inspect: https://vercel.com/carbon-design-system/carbon-website/fk057ur2w
✅ Preview: https://carbon-website-git-fork-joshblack-feat-add-component-images.carbon-design-system.vercel.app

carbondesignsystem – ./

🔍 Inspect: https://vercel.com/carbon-design-system/carbondesignsystem/kupfg5km4
✅ Preview: https://carbondesignsystem-git-fork-joshblack-feat-add-component-images.carbon-design-system.vercel.app

@vercel vercel bot temporarily deployed to Preview – carbon-website August 13, 2020 18:21 Inactive
@vercel vercel bot temporarily deployed to Preview – carbondesignsystem August 13, 2020 18:21 Inactive
@joshblack
Copy link
Contributor Author

@aagonzales would be great if you have a second to see how the images are rendering (I think they're 4x3 at the moment) to catch any potential issues 👀

Copy link
Member

@aagonzales aagonzales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah the ratio looks fine since its just a fixed height. Some of the images look a little too snug but we can fix that within the image itself so that's fine.

@vercel vercel bot temporarily deployed to Preview – carbon-website August 13, 2020 21:03 Inactive
@vercel vercel bot temporarily deployed to Preview – carbondesignsystem August 13, 2020 21:03 Inactive
@kodiakhq kodiakhq bot merged commit 561d5d2 into carbon-design-system:master Aug 13, 2020
@joshblack joshblack deleted the feat/add-component-images branch August 13, 2020 22:50
natashadecoste pushed a commit to natashadecoste/carbon-website that referenced this pull request May 19, 2021
* feat(index): add image data

* feat(index): add images and update entries

* feat(index): update config to include images and update schema

* feat(index): add images to component inde xlist

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
natashadecoste pushed a commit to natashadecoste/carbon-website that referenced this pull request May 19, 2021
* feat(index): add image data

* feat(index): add images and update entries

* feat(index): update config to include images and update schema

* feat(index): add images to component inde xlist

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants