-
Notifications
You must be signed in to change notification settings - Fork 800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(index): add images and update entries #1570
feat(index): add images and update entries #1570
Conversation
…te into feat/add-component-images
This pull request is being automatically deployed with Vercel (learn more). carbon-website – ./🔍 Inspect: https://vercel.com/carbon-design-system/carbon-website/fk057ur2w carbondesignsystem – ./🔍 Inspect: https://vercel.com/carbon-design-system/carbondesignsystem/kupfg5km4 |
@aagonzales would be great if you have a second to see how the images are rendering (I think they're 4x3 at the moment) to catch any potential issues 👀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah the ratio looks fine since its just a fixed height. Some of the images look a little too snug but we can fix that within the image itself so that's fine.
* feat(index): add image data * feat(index): add images and update entries * feat(index): update config to include images and update schema * feat(index): add images to component inde xlist Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
* feat(index): add image data * feat(index): add images and update entries * feat(index): update config to include images and update schema * feat(index): add images to component inde xlist Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
This PR adds in the initial batch of images and sets up the integration for images inside of the component index.
It also addresses some issues I ran into while implementing, namely:
Changelog
New
Changed
Removed