Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(footer): add e2e tests for default language only and micro #7606

Merged
merged 10 commits into from
Nov 9, 2021
Merged

test(footer): add e2e tests for default language only and micro #7606

merged 10 commits into from
Nov 9, 2021

Conversation

ariellalgilmore
Copy link
Member

Related Ticket(s)

#7423 #7426

Description

Create e2e tests for Default Language Only and Micro Footer.

cypress caught that the Default Language Only footer language selector was not clickable, so adding padding to the large breakpoints in storybook

Changelog

New

  • e2e test Default Langauge Selector for desktop/mobile
  • e2e test Micro for desktop/mobile

@ariellalgilmore ariellalgilmore added the test: e2e used for automated e2e testing label Nov 5, 2021
@ariellalgilmore ariellalgilmore requested a review from a team as a code owner November 5, 2021 15:54
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Nov 5, 2021 •
edited
Loading

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/7606/index.html

Built with commit: b233d4d9ef99953de28ba4b7b45e9b324ea0f911

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Nov 5, 2021 •
edited
Loading

Deploy preview created for package Web Components HTML Test Application:
https://ibmdotcom-web-components-html-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/7606/index.html

Built with commit: b233d4d9ef99953de28ba4b7b45e9b324ea0f911

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Nov 5, 2021 •
edited
Loading

Deploy preview created for package React:
https://ibmdotcom-react.s3.us-south.cloud-object-storage.appdomain.cloud/deploy-previews/7606/index.html

Built with commit: b233d4d9ef99953de28ba4b7b45e9b324ea0f911

@ariellalgilmore ariellalgilmore added Needs design approval PRs on feature requests and new components have to get design approval before merge. 👀 eyes needed labels Nov 5, 2021
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Nov 5, 2021 •
edited
Loading

Deploy preview created for package Web Components (React wrapper):
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/7606/index.html

Built with commit: b233d4d9ef99953de28ba4b7b45e9b324ea0f911

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Nov 5, 2021 •
edited
Loading

Deploy preview created for package NextJS Test Application:
https://ibmdotcom-nextjs-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/7606/index.html

Built with commit: b233d4d9ef99953de28ba4b7b45e9b324ea0f911

@github-actions
Copy link
Contributor

github-actions bot commented Nov 5, 2021

CLA Assistant Lite bot: Thank you for your contribution! Please review and sign our Contributor License Agreement before we can review and merge your pull request.

The signature to be committed in order to sign the CLA

You can retrigger this bot by commenting recheck in this Pull Request

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Nov 5, 2021 •
edited
Loading

Deploy preview created for package "Web Components (Codesandbox Examples)":
https://webcomponents-codesandbox.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/7606/index.html

Built with commit: b233d4d9ef99953de28ba4b7b45e9b324ea0f911

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Nov 5, 2021 •
edited
Loading

Deploy preview created for package "React (Codesandbox Examples)":
https://react-codesandbox.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/7606/index.html

Built with commit: b233d4d9ef99953de28ba4b7b45e9b324ea0f911

@github-actions
Copy link
Contributor

github-actions bot commented Nov 6, 2021 •
edited
Loading

DCO Assistant Lite bot All Contributors have signed the CLA.

@ariellalgilmore
Copy link
Member Author

I have read the DCO document and I hereby sign the DCO.

jeffchew
jeffchew approved these changes Nov 8, 2021
View reviewed changes
Copy link
Member

@jeffchew jeffchew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jeffchew jeffchew added Ready to merge Label for the pull requests that are ready to merge and removed 👀 eyes needed labels Nov 8, 2021
@jeffchew jeffchew mentioned this pull request Nov 8, 2021
Closed
@kodiakhq kodiakhq bot removed the Ready to merge Label for the pull requests that are ready to merge label Nov 8, 2021
@kodiakhq
Copy link
Contributor

kodiakhq bot commented Nov 8, 2021

This PR currently has a merge conflict. Please resolve this and then re-add the Ready to merge label.

@shixiedesign
Copy link
Contributor

Hey @ariellalgilmore I can take a look at storybook - but looks like build failed?

@ariellalgilmore
Copy link
Member Author

@shixiedesign just re-built but you should see the changes in the deploy previews

@shixiedesign shixiedesign removed the Needs design approval PRs on feature requests and new components have to get design approval before merge. label Nov 9, 2021
shixiedesign
shixiedesign approved these changes Nov 9, 2021
View reviewed changes
Copy link
Contributor

@shixiedesign shixiedesign left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Yes the padding helped. There might be a Percy diff at some point. I can come back to review that later.

@jeffchew jeffchew added the Ready to merge Label for the pull requests that are ready to merge label Nov 9, 2021
@kodiakhq kodiakhq bot merged commit d27e805 into carbon-design-system:master Nov 9, 2021
@ariellalgilmore ariellalgilmore deleted the feat/footer-tests branch November 9, 2021 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffchew jeffchew jeffchew approved these changes

@shixiedesign shixiedesign shixiedesign approved these changes

@IgnacioBecerra IgnacioBecerra Awaiting requested review from IgnacioBecerra IgnacioBecerra was automatically assigned from carbon-design-system/carbon-for-ibm-com-members

@DragosRistici DragosRistici Awaiting requested review from DragosRistici DragosRistici was automatically assigned from carbon-design-system/carbon-for-ibm-com-members

Assignees

@shixiedesign shixiedesign

Labels
Ready to merge Label for the pull requests that are ready to merge test: e2e used for automated e2e testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ariellalgilmore @ibmdotcom-bot @shixiedesign @jeffchew