-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(tabs-extended): add hyphens auto to handle word breaks #10849
fix(tabs-extended): add hyphens auto to handle word breaks #10849
Conversation
…priately based on lang
Deploy preview created for package Built with commit: 356a89d4a8974c0e237d07bba1be525e1e61e011 |
Deploy preview created for package Built with commit: 356a89d4a8974c0e237d07bba1be525e1e61e011 |
Deploy preview created for package Built with commit: 356a89d4a8974c0e237d07bba1be525e1e61e011 |
Deploy preview created for package Built with commit: 356a89d4a8974c0e237d07bba1be525e1e61e011 |
…carbon-for-ibm-dotcom into ADCMS-3702-tabs-extended-hyphens
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TIL about the hyphens
property. Looks great, @pjudge! One question before the ol' 👍
I will Test in the second week of September, am on annual leave
Deployment Contract Manager #GernePerDu
IBM Technology
+49 160 97.82.86.85
***@***.***
IBM Deutschland
IBM-Allee 1
71139 Ehningen
IBM Deutschland GmbH / Vorsitzender des Aufsichtsrats: Sebastian Krause
Geschäftsführung: Gregor Pillen (Vorsitzender), Dr. Andreas Buchelt, Gabriele Schwarenthorer, Christine Rupp, Frank Theisen
Sitz der Gesellschaft: Ehningen / Registergericht: Amtsgericht Stuttgart, HRB 14562 / WEEE-Reg.-Nr. DE 99369940
On 22. Aug 2023, at 15:49, Andy Blum ***@***.***> wrote:
@StefanieSchraub as the reporter of this ticket and someone that I'm guessing has a better grasp on the German language than I do. Would you be able to test this fix by altering the values on the de-de version of the deploy preview? —Reply
ZjQcmQRYFpfptBannerStart
This Message Is From an External Sender
This message came from outside your organization.
<https://us-phishalarm-ewt.proofpoint.com/EWT/v1/PjiDSg!1i-rqJY1AVJZEK8Ts6uuTYJMRbIJGwtsm7-SrY_5pRaUMtJyU3T2RcjBhYyZLnPFMdUqcIJkWePYM19BBJO_QEE2AVKVNZIE_Bsfa8CjGcgC_ngq6kS7j4WvUiNE9n6qop3p4_L7ezL1yQ$>
Report Suspicious
ZjQcmQRYFpfptBannerEnd
@StefanieSchraub<https://github.com/StefanieSchraub> as the reporter of this ticket and someone that I'm guessing has a better grasp on the German language than I do. Would you be able to test this fix by altering the values on the de-de version of the deploy preview<https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/10849/iframe.html?id=components-tabs-extended--default&viewMode=story&cc=de&lc=de>?
—
Reply to this email directly, view it on GitHub<#10849 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AGBGGPUE4E3U43RKQWWHQC3XWS2GLANCNFSM6AAAAAA3V5EV2E>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
…sign-system#10849) * fix(tabs-extended): add hyphens auto to handle long word breaks appropriately based on lang * fix(tabs-extended): add hyphens auto to accordion title * fix(tabs-extended): replace blank line --------- Co-authored-by: kennylam <909118+kennylam@users.noreply.github.com>
Related Ticket(s)
Closes #10645
Description
If there happens to be a long word inside a tab,
word-break: break-word
would make the text wrap in a grammatically incorrect way. This PR updates the tab text style to use a property that can appropriately break words based on language, and add hyphens.Changelog
Changed
word-break: break-word
withhyphens:auto
for tabs on desktop and accordion titles for mobile.