Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tabs-extended): add hyphens auto to handle word breaks #10849

Merged

Conversation

pjudge
Copy link
Contributor

@pjudge pjudge commented Aug 18, 2023

Related Ticket(s)

Closes #10645

Description

If there happens to be a long word inside a tab, word-break: break-word would make the text wrap in a grammatically incorrect way. This PR updates the tab text style to use a property that can appropriately break words based on language, and add hyphens.

Changelog

Changed

  • Replace word-break: break-word with hyphens:auto for tabs on desktop and accordion titles for mobile.

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Aug 18, 2023

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Aug 18, 2023

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Aug 18, 2023

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Aug 18, 2023

@pjudge pjudge marked this pull request as ready for review August 21, 2023 16:37
@pjudge pjudge requested a review from a team as a code owner August 21, 2023 16:37
Copy link
Member

@jkaeser jkaeser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL about the hyphens property. Looks great, @pjudge! One question before the ol' 👍

@StefanieSchraub
Copy link

StefanieSchraub commented Aug 23, 2023 via email

@andy-blum
Copy link
Member

e2e-tests / web-components failed on OOM error, but parallel tests have all passed.

@kennylam kennylam added the Ready to merge Label for the pull requests that are ready to merge label Aug 25, 2023
@kennylam kennylam merged commit 09c9468 into carbon-design-system:main Aug 29, 2023
23 of 25 checks passed
m4olivei pushed a commit to m4olivei/carbon-for-ibm-dotcom that referenced this pull request Aug 31, 2023
…sign-system#10849)

* fix(tabs-extended): add hyphens auto to handle long word breaks appropriately based on lang

* fix(tabs-extended): add hyphens auto to accordion title

* fix(tabs-extended): replace blank line

---------

Co-authored-by: kennylam <909118+kennylam@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tab size too small for translated terms and wrong word division
7 participants