Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(button-group): small breakpoints alignments #10802

Merged
merged 5 commits into from
Aug 11, 2023
Merged

fix(button-group): small breakpoints alignments #10802

merged 5 commits into from
Aug 11, 2023

Conversation

ariellalgilmore
Copy link
Member

@ariellalgilmore ariellalgilmore commented Aug 8, 2023 •
edited
Loading

Related Ticket(s)

Closes #9574

Description

Change button group alignment for md breakpoint

Changelog

Changed

-change styles from lg to md for breakpoint

  • small breakpoint no longer has max-width

@ariellalgilmore ariellalgilmore added the package: styles Work necessary for the Carbon for IBM.com styles package label Aug 8, 2023
@ariellalgilmore ariellalgilmore requested a review from a team as a code owner August 8, 2023 18:50
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Aug 8, 2023 •
edited
Loading

Deploy preview created for package React:
https://ibmdotcom-react.s3.us-south.cloud-object-storage.appdomain.cloud/deploy-previews/10802/index.html

Built with commit: cc144ea7b7228ae01829bb01c3a6bece96f1280c

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Aug 8, 2023 •
edited
Loading

Deploy preview created for package Carbon Web Components:
https://carbon-web-components.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/10802/index.html

Built with commit: cc144ea7b7228ae01829bb01c3a6bece96f1280c

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Aug 8, 2023 •
edited
Loading

Deploy preview created for package Web Components (React wrapper):
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/10802/index.html

Built with commit: cc144ea7b7228ae01829bb01c3a6bece96f1280c

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Aug 8, 2023 •
edited
Loading

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/10802/index.html

Built with commit: cc144ea7b7228ae01829bb01c3a6bece96f1280c

@IgnacioBecerra IgnacioBecerra added the Ready to merge Label for the pull requests that are ready to merge label Aug 8, 2023
@ariellalgilmore ariellalgilmore added Needs design approval PRs on feature requests and new components have to get design approval before merge. and removed Ready to merge Label for the pull requests that are ready to merge labels Aug 9, 2023
@oliviaflory
Copy link
Contributor

oliviaflory commented Aug 11, 2023 •
edited by ariellalgilmore
Loading

@ariellalgilmore Thank you! This looks great for the medium breakpoint 😄

I might not have been clear enough in our Slack exchange, we also want to adjust the small breakpoint to the following:

  • remove the max width on the buttons (I think we have a limit of 320px right now?)
  • in small breakpoint the buttons should span the 4 columns (see spec screen shot below)
Screenshot 2023-08-11 at 8 28 32 AM

@RichKummer is familiar with the updates if you have any questions today and understand if this needs to roll into next week too.

@ariellalgilmore ariellalgilmore changed the title fix(button-group): md breakpoint alignment fix(button-group): small breakpoints alignments Aug 11, 2023
@ariellalgilmore
Copy link
Member Author

thanks @oliviaflory ! just updated fyi: @RichKummer

RichKummer
RichKummer approved these changes Aug 11, 2023
View reviewed changes
Copy link

@RichKummer RichKummer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @ariellalgilmore for the fix!

@RichKummer RichKummer removed the Needs design approval PRs on feature requests and new components have to get design approval before merge. label Aug 11, 2023
@ariellalgilmore ariellalgilmore added the Ready to merge Label for the pull requests that are ready to merge label Aug 11, 2023
@RichKummer RichKummer mentioned this pull request Aug 11, 2023
Closed
@kodiakhq kodiakhq bot merged commit 1b2e55f into carbon-design-system:main Aug 11, 2023
22 of 25 checks passed
@ariellalgilmore ariellalgilmore deleted the fix/button-group-md-breakpoint branch August 14, 2023 17:31
m4olivei pushed a commit to m4olivei/carbon-for-ibm-dotcom that referenced this pull request Aug 31, 2023
@ariellalgilmore @m4olivei
fix(button-group): small breakpoints alignments (carbon-design-system…
dc58ee4 
…#10802)

### Related Ticket(s)

Closes carbon-design-system#9574 

### Description

Change button group alignment for md breakpoint
### Changelog


**Changed**

-change styles from `lg` to `md` for breakpoint
- small breakpoint no longer has max-width


<!-- React and Web Component deploy previews are enabled by default. -->
<!-- To enable additional available deploy previews, apply the following -->
<!-- labels for the corresponding package: -->
<!-- *** "test: e2e": Codesandbox examples and e2e integration tests -->
<!-- *** "package: services": Services -->
<!-- *** "package: utilities": Utilities -->
<!-- *** "RTL": React / Web Components (RTL) -->
<!-- *** "feature flag": React / Web Components (experimental) -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IgnacioBecerra IgnacioBecerra IgnacioBecerra approved these changes

@RichKummer RichKummer RichKummer approved these changes

@emyarod emyarod Awaiting requested review from emyarod emyarod is a code owner automatically assigned from carbon-design-system/carbon-for-ibm-com-members

@annawen1 annawen1 Awaiting requested review from annawen1 annawen1 is a code owner automatically assigned from carbon-design-system/carbon-for-ibm-com-members

@oliviaflory oliviaflory Awaiting requested review from oliviaflory

Assignees
No one assigned
Labels
package: styles Work necessary for the Carbon for IBM.com styles package Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Button group]: mobile width
5 participants
@ariellalgilmore @ibmdotcom-bot @oliviaflory @RichKummer @IgnacioBecerra