Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(leaving-ibm): update body content padding #10583

Merged
merged 2 commits into from
Jun 23, 2023
Merged

fix(leaving-ibm): update body content padding #10583

merged 2 commits into from
Jun 23, 2023

Conversation

kennylam
Copy link
Member

Related Ticket(s)

Fixes #7416

Description

Update body content padding in leaving-ibm component.

Changelog

New

  • {{new thing}}

Changed

  • update body content padding

Removed

  • {{removed thing}}

@kennylam kennylam added the package: web components Work necessary for the IBM.com Library web components package label Jun 21, 2023
@kennylam kennylam requested a review from a team as a code owner June 21, 2023 19:17
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jun 21, 2023 •
edited
Loading

Deploy preview created for package Carbon Web Components:
https://carbon-web-components.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/10583/index.html

Built with commit: c15d3cf02929df9230ff91e8eda4cd0a8965a3d9

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jun 21, 2023 •
edited
Loading

Deploy preview created for package React:
https://ibmdotcom-react.s3.us-south.cloud-object-storage.appdomain.cloud/deploy-previews/10583/index.html

Built with commit: c15d3cf02929df9230ff91e8eda4cd0a8965a3d9

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jun 21, 2023 •
edited
Loading

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/10583/index.html

Built with commit: c15d3cf02929df9230ff91e8eda4cd0a8965a3d9

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jun 21, 2023 •
edited
Loading

Deploy preview created for package Web Components (React wrapper):
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/10583/index.html

Built with commit: c15d3cf02929df9230ff91e8eda4cd0a8965a3d9

@kennylam kennylam force-pushed the fix/leaving-ibm-content-width branch from 1484bbf to d1bb887 Compare June 21, 2023 19:50
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jun 21, 2023 •
edited
Loading

Deploy preview created for package Web Components HTML Test Application:
https://ibmdotcom-web-components-html-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/10583/index.html

Built with commit: c15d3cf02929df9230ff91e8eda4cd0a8965a3d9

ariellalgilmore
ariellalgilmore approved these changes Jun 21, 2023
View reviewed changes
Copy link
Member

@ariellalgilmore ariellalgilmore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jun 21, 2023 •
edited
Loading

Deploy preview created for package NextJS Test Application:
https://ibmdotcom-nextjs-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/10583/index.html

Built with commit: d1bb887ab87f97006806a870df42809918077689

@IgnacioBecerra IgnacioBecerra added the Ready to merge Label for the pull requests that are ready to merge label Jun 22, 2023
@kodiakhq kodiakhq bot merged commit e3df01e into carbon-design-system:main Jun 23, 2023
@kennylam kennylam deleted the fix/leaving-ibm-content-width branch November 21, 2023 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IgnacioBecerra IgnacioBecerra IgnacioBecerra approved these changes

@ariellalgilmore ariellalgilmore ariellalgilmore approved these changes

@oliviaflory oliviaflory Awaiting requested review from oliviaflory

Assignees
No one assigned
Labels
package: web components Work necessary for the IBM.com Library web components package Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Carbon 10.46 upgrade Leaving IBM]: Text breaking earlier than expected
4 participants
@kennylam @ibmdotcom-bot @ariellalgilmore @IgnacioBecerra