Skip to content

incorrect typedefinition for TranslationStrings (fix suggested) #3032

Open

Description

This is an incorrect type definition for TranslationStrings

https://github.com/carbon-design-system/carbon-components-angular/blob/7967695ff011a0e42761f4fcf766820bdd2e1bef/src/i18n/i18n.service.ts#L138C1-L138C60

it should in fact support nested values like in the en.ts file

i suggest to modify it to

export type TranslationStrings = {
  [key: string]: string | { [key: string]: string | TranslationStrings };
};

Thanks

latest carbon-angular-components. version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions