-
Notifications
You must be signed in to change notification settings - Fork 24
feat(api): image building process improvement #404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
611a9e2 to
2d620f7
Compare
…trigger for sdk workflow
… get artifact service type
e31acbe to
458bed7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This PR contains improvement for
pyfunc-ensembler-service/pyfunc-ensembler-jobimage building process. This improvement removes the need of supporting specific python versions and use the python version specified in user dependency instead, similar on how merlin buildspyfunc-serverandbatch-predictorimages.Changes in this PR includes improvement for the imagebuilder,
pyfunc-ensembler-service/pyfunc-ensembler-jobpackage, and little bit ofsdk.imagebuilder
pyfunc-ensembler-service/pyfunc-ensembler-jobdependency to user's conda.yaml.conda.yamlto prevent the URL value ofconda.yamlthat has the same content to change and invalidating docker layer cache.pyfunc-ensembler-service/pyfunc-ensembler-jobpackagesdkworkflow is run successfully.pyfunc-ensembler-service/pyfunc-ensembler-jobshare the same version withturing-sdkpackage, but both of these package requires latestturing-sdkversion, so we need to run the workflow only aftersdkworkflow completed.sdk
sdkworkflow topython/*tag push instead ofsdk/*tag push.python/*tag and version will be used byturing-sdk,pyfunc-ensembler-serviceandpyfunc-ensembler-jobpackages.Main Modifications
imagebuilder/imagebuilder.go:--build-arg=BASE_IMAGE=%svalueconda.yamlengines/pyfunc-ensembler-*/Makefile:pyfunc-ensembler-*packageengines/pyfunc-ensembler-*/app.Dockerfile:turing-pyfunc-ensembler-*to user's dependency.github/workflows/*python/*tag assdkworkflow triggerspyfunc-ensembler-*workflow aftersdkworkflow is run successfully