fix(api): Refactor JobState to string #379
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #379 +/- ##
==========================================
- Coverage 67.96% 62.12% -5.84%
==========================================
Files 149 124 -25
Lines 11773 9747 -2026
==========================================
- Hits 8001 6055 -1946
+ Misses 3036 2956 -80
Partials 736 736
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous JobState is
intand usesiotatogether in the same const block with other values. This lead to JobState is starting from 3 instead of 0.Using
intforJobStaterequires mapping implementation in SDK.This PR refactors JobState from
inttostringso that it easier to parse by SDK and to make it consistent with Merlin implementation (https://github.com/caraml-dev/merlin/blob/main/api/models/version_image.go#L15-L20).