Skip to content

Conversation

@ariefrahmansyah
Copy link
Contributor

@ariefrahmansyah ariefrahmansyah commented Apr 29, 2024

Description

The image-building process of the Turing ensembler jobs and services are tightly coupled with the serving flow. If the image-building failed, the serving would fail too.

This PR introduces a new Image Building API to trigger the image building process programmatically and separately from the serving flow.

Modifications

  1. Add new Image Building API which calls the new Image Building Service layer
    a. Add ListImages endpoint that will return the job and services images for a given ensembler.
    b. Add BuildImage endpoint that will build an job or service image
  2. Add Image Building Service layer which calls the imagebuilder/imagebuilder.go

Tests

Checklist

  • Added PR label
  • Added unit test, integration, and/or e2e tests
  • Tested locally
  • Updated documentation
  • Update Swagger spec if the PR introduce API changes
  • Regenerated Golang and Python client if the PR introduces API changes

Release Notes

NONE

@ariefrahmansyah ariefrahmansyah marked this pull request as ready for review May 6, 2024 05:27
@codecov
Copy link

codecov bot commented May 6, 2024

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

Copy link
Contributor

@deadlycoconuts deadlycoconuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for this super long PR. I've left some comments which might no longer be relevant anymore after your latest pushes 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request type: feature New feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants