Open
Conversation
fabricedesre
requested changes
Mar 19, 2024
Contributor
fabricedesre
left a comment
fabricedesre
left a comment
There was a problem hiding this comment.
Thanks for doing that! I commented some needed changes. Can you also upload before / after screenshots?
Author
|
Sure! Will do that later tomorrow. |
Author
|
I couldn't upload screenshot because I had to re-install Windows and I didn't have the WSL since of fresh install. |
Author
|
I removed the font "ReadexPro" from the files of the Dialer app, and I have kept the default font the app had. The UI is now a bit improved for the dialer. |
Author
|
Here is a before/after comparison (I don't know why it has to scroll |
Contributor
|
It should not have to scroll. That looks like a regression from your changes. |
Author
|
Ok, I'll try updating it later.. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello! I tried improving the dialer app for nutria using a better UI.