Skip to content

Upgrade webpack to fix travis build #274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 23, 2019

Conversation

ignatiusreza
Copy link
Contributor

@ignatiusreza ignatiusreza commented Feb 21, 2019

Followup of #273 (might need to be rebased)

Both webpack and webpack-dev-server in master depends transitively on upath@1.0.2 which locked node engine at >=4 <=9, even though travis is using v11.10.0..

This was referenced Feb 21, 2019
@vcarl
Copy link
Contributor

vcarl commented Feb 23, 2019

Rebased this branch to current master. Everything builds, so gonna merge it, thanks for upgrading stuff!!

@vcarl vcarl merged commit 6da9bd2 into captivationsoftware:master Feb 23, 2019
@vcarl
Copy link
Contributor

vcarl commented Feb 23, 2019

screenshot 2019-02-22 23 48 29

🎉 🎉

@ignatiusreza ignatiusreza deleted the upgrade/webpack branch February 23, 2019 04:54
@ignatiusreza
Copy link
Contributor Author

Thanks! Glad to help.. 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants