Fix event x/y by finding container node #849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modern/src/App.js
Outdated
| relativeParent = relativeParent.offsetParent; | ||
| } | ||
| const x = event.clientX - relativeParent.offsetLeft; | ||
| const y = event.clientY - relativeParent.offsetTop; |
There was a problem hiding this comment.
I was imagining we would do this by traversing up our own state tree (Maki or Redux) until we find a container, and then using the x/y values that we currently have from the last time we set them.
There was a problem hiding this comment.
oh yea, thats much much better!
There was a problem hiding this comment.
yea, just fixed it...SO MUCH BETTER!!!
jberg
changed the title
captbaritone
pushed a commit
that referenced
this pull request
Nov 30, 2019
* Fix event x/y by finding relativeParent * use a tree search to find the container instead of event target hacks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to calculate x/y based off of the "top" absolute positioned element, so follow
offsetParentup the chain. Probably gets rid of the forced layout too