Integration with music-metadata-browser #673
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-metadata / strtok3.
…/*`. The relative URL used for 'Llama DJ Mike Llama' results in a MIME-type: `audio/mpeg; charset=UTF-8`.
# Conflicts: # config/webpack.common.js
…music-metadata
Pass MIME-type parameters to music-metadata.
# Conflicts: # js/actionCreators/files.js
… headers are searched in a stream. Enable that flag in WebAmp.
This reverts commit 472c2c0.
Prevents WebPack compile warnings.
This reverts commit 5f1fbe7.
This reverts commit 1070c15.
# Conflicts: # js/actionCreators/files.js # js/fileUtils.js # package.json
# Conflicts: # js/actionCreators/files.ts # js/actionCreators/index.js # js/config.ts # js/fileUtils.ts # js/mediaMiddleware.ts
|
Cool stuff @Borewit! Seems like the duration is a bit off on the songs though. Also, unfortunately, Firefox will download the whole song. |
Can you give me an example @durasj? Feel free to open an issue.
Indeed, apperently the |
|
So I've checked it again and it seems to be the duration of the current song that's wrong. See gif: |
Borewit
added a commit
to Borewit/webamp
that referenced
this pull request
Oct 17, 2018
Borewit
added a commit
to Borewit/webamp
that referenced
this pull request
Oct 17, 2018
captbaritone
pushed a commit
that referenced
this pull request
Oct 18, 2018
captbaritone
pushed a commit
that referenced
this pull request
Oct 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using Web Fetch API, thanks for the idea @durasj.#606
This is a continuation of the branch of close PR #606. I wanted to know how music-metadata-browser behaved in WebAmp.
After PR #606, I opened #634 (making use of the tag event updates while parsing). Although I believe that is a nicer solution on the long run, I think music-metadata has to be merged in first with the least amount of change to avoid PR's have to be maintained forever.
Another difference is that this is build music-metadata-browser and no longer directly on music-metadata. music-metadata-browser is tailered to the needs of JavaScript module based browser applications and driven by the requirements of WebAmp.
So this PR is back to basics.
Preview: 🚀 Music-metadata powered WebAmp