add support for datalinks other than ethernet#145
Draft
drunkirishcoder wants to merge 18 commits intodjin/0.2.0-alphafrom
Draft
add support for datalinks other than ethernet#145drunkirishcoder wants to merge 18 commits intodjin/0.2.0-alphafrom
drunkirishcoder wants to merge 18 commits intodjin/0.2.0-alphafrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #145 +/- ##
==========================================
+ Coverage 68.40% 76.44% +8.04%
==========================================
Files 66 50 -16
Lines 5972 5048 -924
==========================================
- Hits 4085 3859 -226
+ Misses 1887 1189 -698
Continue to review full report at Codecov.
|
d478ea2 to
c7c9f1d
Compare
8e818aa to
74ab2b5
Compare
74ab2b5 to
7576270
Compare
bffcbb9 to
1232a4c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add a trait
Datalinkthat makes it possible to support a different datalink for IP packets. The only other applicable datalink supported by DPDK is InfiniBand through Mellanox NICs. #144This is a breaking change. Previously it was assumed that IP packets (both v4 and v6) will only be encapsulated inside an Ethernet frame, which is the overwhelming majority of the use case of DPDK. After the change, the struct becomes a generic struct,
Ipv4<E: Datalink>.Type of change
Checklist