Skip to content

Add workflow for building on Windows #2675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 9, 2025

Conversation

stevenjoezhang
Copy link
Contributor

@stevenjoezhang stevenjoezhang commented Apr 5, 2025

Your checklist for this pull request

  • I've documented or updated the documentation of every API function and struct this PR changes.
  • I've added tests that prove my fix is effective or that my feature works (if possible)

Detailed description

See #2674

Test plan

You can checkout the workflow on my forked version: https://github.com/stevenjoezhang/capstone/actions/runs/14284910369
An installer is available for download

Closing issues

Closes #2153

@github-actions github-actions bot added the Github-files Github related files label Apr 5, 2025
@Rot127
Copy link
Collaborator

Rot127 commented Apr 6, 2025

The build fails when I do a test release. See: https://github.com/Rot127/capstone/actions/runs/14291716748/job/40053779251

@stevenjoezhang stevenjoezhang force-pushed the next branch 2 times, most recently from 3e77df2 to 3ef35e8 Compare April 6, 2025 14:46
Copy link
Collaborator

@Rot127 Rot127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested already with a previous version and it was fine. Also installing with a Windows VM and running cstool worked out.

Will test a last time once all is green. This would be also the last PR before we release Alpha4. So if you have any last additions...

@stevenjoezhang
Copy link
Contributor Author

I think there are two issues here:

  1. On Linux, CMake failed because this PR caused the Create archive step to execute mv * /tmp/$PKGNAME and mv /tmp/$PKGNAME ., resulting in CMake being unable to find CMakeLists.txt.
  2. On Windows, CMake failed due to missing quotes, which caused PowerShell to misinterpret the arguments.

Both of these issues have now been fixed. See https://github.com/stevenjoezhang/capstone/actions/runs/14293644558

@Rot127
Copy link
Collaborator

Rot127 commented Apr 6, 2025

You can ignore the failing test.

Copy link
Collaborator

@Rot127 Rot127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Rot127
Copy link
Collaborator

Rot127 commented Apr 8, 2025

Can you quickly press the rebase button please. Just so the test is green.

Copy link
Member

@kabeor kabeor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thank you! Merged.

@kabeor kabeor merged commit ebe3ef2 into capstone-engine:next Apr 9, 2025
20 checks passed
kabeor pushed a commit that referenced this pull request Apr 9, 2025
* Add workflow for building on Windows

* Fix build
Rot127 pushed a commit that referenced this pull request Apr 11, 2025
* Add workflow for building on Windows

* Fix build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Github-files Github related files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows precompiled binaries
3 participants