-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Add workflow for building on Windows #2675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The build fails when I do a test release. See: https://github.com/Rot127/capstone/actions/runs/14291716748/job/40053779251 |
3e77df2
to
3ef35e8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested already with a previous version and it was fine. Also installing with a Windows VM and running cstool
worked out.
Will test a last time once all is green. This would be also the last PR before we release Alpha4. So if you have any last additions...
I think there are two issues here:
Both of these issues have now been fixed. See https://github.com/stevenjoezhang/capstone/actions/runs/14293644558 |
You can ignore the failing test. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Can you quickly press the rebase button please. Just so the test is green. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, thank you! Merged.
* Add workflow for building on Windows * Fix build
* Add workflow for building on Windows * Fix build
Your checklist for this pull request
Detailed description
See #2674
Test plan
You can checkout the workflow on my forked version: https://github.com/stevenjoezhang/capstone/actions/runs/14284910369
An installer is available for download
Closing issues
Closes #2153