Skip to content

[v4] Add meta-programming macros for ARM64/AArch64 name change to capstone.h #2200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 19, 2023

Conversation

Rot127
Copy link
Collaborator

@Rot127 Rot127 commented Nov 17, 2023

Adds the meta programming macros for the ARM64 -> AArch64 name change to the v4 branch.

@Rot127 Rot127 changed the title Add meta-programming macros for ARM64/AArch64 name change to capstone.h [v4] Add meta-programming macros for ARM64/AArch64 name change to capstone.h Nov 17, 2023
@kabeor
Copy link
Member

kabeor commented Nov 19, 2023

Considering we no longer maintain the v4 version, no need to bother with it. I will close this PR, if you have any ideas, feel free to reopen it :)

@kabeor kabeor closed this Nov 19, 2023
@Rot127
Copy link
Collaborator Author

Rot127 commented Nov 19, 2023

Considering that v5 is only a few months old we should merge this nonetheless IMHO.
There might be some who still have v4 running and want to go directly to v6.

@kabeor
Copy link
Member

kabeor commented Nov 19, 2023

But the people who want to use v6 will install v6 directly, so the capstone.h will be overlay right?

@Rot127
Copy link
Collaborator Author

Rot127 commented Nov 19, 2023

Not if different versions of Capstone are cloned as sub-module. If a project's code needs to be compatible with v4, v5 and v6 each, they simply can use those macros in their code to wrap it around enum names and the like (e.g. CS_AARCH64(INS_BR)).
Hence those macros need to be present in any version of Capstone they clone.

Or do I miss your point?

@kabeor
Copy link
Member

kabeor commented Nov 19, 2023

Well, that's a good point. Merged.

@kabeor kabeor merged commit 975a4f1 into capstone-engine:v4 Nov 19, 2023
@Rot127 Rot127 deleted the AArch64-meta-macros-v4 branch November 19, 2023 15:28
@kabeor
Copy link
Member

kabeor commented Nov 19, 2023

Oh, still, we need tests. @Rot127

@XVilka
Copy link
Contributor

XVilka commented Nov 21, 2023

It probably even makes sense to release a small patch version in 4.x series

@Rot127 Rot127 added this to the v4.0.3 milestone Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants