Skip to content

Fix register accesses on x86 'test' instruction #1751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 17, 2021

Conversation

Quentin01
Copy link
Contributor

test doesn't modify any of it's operands according to the intel documentation. In some cases, capstone reports that the first operand is written.

I don't know if those files should be modified by hands but that's what I did, if I should do it differently let me know.

@aquynh
Copy link
Collaborator

aquynh commented May 12, 2021

can you make pull req for the v4 branch instead, please?

@tmfink
Copy link
Contributor

tmfink commented May 12, 2021

can you make pull req for the v4 branch instead, please?

@aquynh Since we only use next and the version branches (like v4). Could we make next the default branch?

https://docs.github.com/en/github/administering-a-repository/changing-the-default-branch#changing-the-default-branch

We could also delete or put a notice in the master branch to migrate to the next for version branch.

@Quentin01 Quentin01 force-pushed the fix-test-registers-accesses branch from 8e73924 to 63447f0 Compare May 12, 2021 06:35
@Quentin01 Quentin01 changed the base branch from master to v4 May 12, 2021 06:35
@Quentin01
Copy link
Contributor Author

I changed it to merge on the v4 branch.

@aquynh aquynh merged commit a7cac83 into capstone-engine:v4 May 17, 2021
@aquynh
Copy link
Collaborator

aquynh commented May 17, 2021

merged, thanks!

@aquynh
Copy link
Collaborator

aquynh commented May 17, 2021

can you make pull req for the v4 branch instead, please?

@aquynh Since we only use next and the version branches (like v4). Could we make next the default branch?

https://docs.github.com/en/github/administering-a-repository/changing-the-default-branch#changing-the-default-branch

We could also delete or put a notice in the master branch to migrate to the next for version branch.

yes, i plan to do so. but perhaps it is better to move this whole repo to an organization, so more people can join to manage the project.

@tmfink
Copy link
Contributor

tmfink commented May 17, 2021

yes, i plan to do so. but perhaps it is better to move this whole repo to an organization, so more people can join to manage the project.

That's good news. Note that migrating the repo under a new organization is independent of changing the default branch (you can do one but not the other).

kazarmy pushed a commit to rizinorg/capstone that referenced this pull request Nov 29, 2021
@Hyask Hyask deleted the fix-test-registers-accesses branch April 20, 2022 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants