Fixed anonymous type in anonymous union error in m68k.h #1597
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
netromdk
changed the title
|
@emoon please ack |
|
Any update on this? Thanks :) |
|
Sorry the notification must have been eaten by some spam filter :( it looks good! |
aquynh
reviewed
Mar 18, 2020
include/capstone/m68k.h
Outdated
| @@ -150,17 +150,20 @@ typedef struct m68k_op_br_disp { | |||
| uint8_t disp_size; ///< Size from m68k_op_br_disp_size type above | |||
| } m68k_op_br_disp; | |||
|
|
|||
| /// Register pair in one operand. | |||
| typedef struct cs_m68k_op_reg_pair { | |||
| m68k_reg reg_0; | |||
There was a problem hiding this comment.
please use tabs for indentation, not spaces.
There was a problem hiding this comment.
I've converted into tabs now.
Apple Clang 11.0.0 error:
```
capstone/include/capstone/m68k.h:160:3: error: anonymous types declared in an anonymous union are an extension [-Werror,-Wnested-anon-types]
struct { ///< register pair in one operand
^
```
netromdk
force-pushed
the
fix_anon_type_in_anon_union
branch
from
9bc8f9a to
7026cee
Compare
|
merged, thanks! |
aquynh
pushed a commit
that referenced
this pull request
Mar 19, 2020
Apple Clang 11.0.0 error:
```
capstone/include/capstone/m68k.h:160:3: error: anonymous types declared in an anonymous union are an extension [-Werror,-Wnested-anon-types]
struct { ///< register pair in one operand
^
```
aquynh
pushed a commit
that referenced
this pull request
Mar 19, 2020
Apple Clang 11.0.0 error:
```
capstone/include/capstone/m68k.h:160:3: error: anonymous types declared in an anonymous union are an extension [-Werror,-Wnested-anon-types]
struct { ///< register pair in one operand
^
```
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apple Clang 11.0.0 error: